Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add information for schedules #366

Merged
merged 10 commits into from
Jul 24, 2023
Merged

feat: add information for schedules #366

merged 10 commits into from
Jul 24, 2023

Conversation

jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Jun 8, 2023

closes: go-vela/community#538

Part of go-vela/community#772

This adds API, CLI and usage documentation for schedules.

@jbrockopp jbrockopp self-assigned this Jun 8, 2023
@jbrockopp jbrockopp marked this pull request as ready for review June 8, 2023 19:53
@jbrockopp jbrockopp requested a review from a team as a code owner June 8, 2023 19:53
@wass3rw3rk
Copy link
Member

i'll convert to draft for now and open it when we do the release - thank you!

@wass3rw3rk wass3rw3rk marked this pull request as draft June 8, 2023 20:26
@wass3rw3rk wass3rw3rk added the next label Jun 8, 2023
@wass3rw3rk
Copy link
Member

wass3rw3rk commented Jun 22, 2023

do you think we should call out that builds triggered by schedules count against existing build limits?

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Jun 22, 2023

it should probably be called out the current experience runs the job on the next sweep depending tied to minimum frequency and then in the interval defined by the cron expression. also, that defining specific times in the cron expression aren't valid since it's only concerned with the interval.

@wass3rw3rk wass3rw3rk marked this pull request as ready for review July 17, 2023 19:30
@plyr4 plyr4 merged commit 03ababe into main Jul 24, 2023
2 checks passed
@plyr4 plyr4 deleted the feature/schedules branch July 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CRON/scheduled jobs
5 participants