fix(mock): add approve build to mock #5163
ecrupperreviewdog.yml
on: pull_request
diff-review
1m 34s
full-review
1m 43s
Annotations
20 errors
|
diff-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
diff-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
diff-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
diff-review:
cmd/vela-server/schedule.go#L138
cyclomatic complexity 31 of func `processSchedule` is high (> 30) (gocyclo)
|
|
diff-review:
mock/server/build.go#L306
Comment should end in a period (godot)
|
|
diff-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
diff-review:
database/executable/table.go#L38
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
full-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
full-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
full-review:
cmd/vela-server/schedule.go#L138
cyclomatic complexity 31 of func `processSchedule` is high (> 30) (gocyclo)
|
|
full-review:
mock/server/build.go#L306
Comment should end in a period (godot)
|
|
full-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
full-review:
database/log/update.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|