-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bodoni by Indestructible Type #1848
Comments
Hi! The Bodoni Moda branch of Bodoni* is currently passing all fontbakery checks for the static builds of the font. However it still throws up an error for the variable font version. This is due to naming conventions. Right now the typeface has different versions for various point sizes. These are considered different font families in the static builds, but should all be incorporated as one for the variable. As it stands they are stylename mapped to "11 Regular", "72 Bold" etc., with the point size appearing as a number before the weight. This causes fontbakery to have an issue as "72 Bold" isn't an expected stylename. Understandable, but I can't think of a suitable solution. What should we do about this? |
@EwonRael we've recently changed our instance naming policy, https://github.com/googlefonts/gf-docs/tree/master/Spec#fvar-instances. For instance names, we only allow weight and italic particles. However, we expect these styles should be included in a STAT table. If it still remains unclear, open an issue in the docs and we'll improve them. |
The family name can't just be Bodoni, it needs to be Bodoni Moda
…On Mon, Jul 20, 2020, 9:28 AM Marc Foley ***@***.***> wrote:
@EwonRael <https://github.com/EwonRael> we've recently changed our
instance naming policy,
https://github.com/googlefonts/gf-docs/tree/master/Spec#fvar-instances.
We don't allow any particles other than weight and italic to be included
in instance names. However, we expect these styles should be included in a
STAT table.
Read the docs and if it still remains unclear, open an issue and we'll
improve the docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1848 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB73S4F3PG6KBO43USHZVLR4RA7VANCNFSM4GWRNV2Q>
.
|
okay so the Bodoni Moda branch now static+variable fonts that pass all fontbakery tests and should conform to the instance naming/STAT policy. Don't worry @davelab6 as long as we're pulling from the google branch or using the build-GF.sh script the family name is "Bodoni Moda" Let me know how things look |
I'm thinking everything is good on my end to push to GF? Let me know if I'm mistaken about this or if there's something more I should be doing? |
Why isn't the full project called Bodoni Moda? |
should I make a separate repo for Bodoni Moda naming convention? |
https://github.com/indestructible-type/Bodoni
Production notes from Rosa:
The text was updated successfully, but these errors were encountered: