Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bodoni by Indestructible Type #1848

Closed
5 tasks done
m4rc1e opened this issue Feb 11, 2019 · 7 comments · Fixed by #2833
Closed
5 tasks done

Add Bodoni by Indestructible Type #1848

m4rc1e opened this issue Feb 11, 2019 · 7 comments · Fixed by #2833
Assignees

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 11, 2019

https://github.com/indestructible-type/Bodoni

Production notes from Rosa:

  • Contact designer about this
  • Correct sources (upright)
  • Correct sources (italic)
  • Re-make build system
  • Package
@laerm0 laerm0 added this to the Add New Families milestone Feb 11, 2019
@EwonRael
Copy link
Contributor

Hi!

The Bodoni Moda branch of Bodoni* is currently passing all fontbakery checks for the static builds of the font. However it still throws up an error for the variable font version.

This is due to naming conventions. Right now the typeface has different versions for various point sizes. These are considered different font families in the static builds, but should all be incorporated as one for the variable. As it stands they are stylename mapped to "11 Regular", "72 Bold" etc., with the point size appearing as a number before the weight.

This causes fontbakery to have an issue as "72 Bold" isn't an expected stylename. Understandable, but I can't think of a suitable solution.

What should we do about this?

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jul 20, 2020

@EwonRael we've recently changed our instance naming policy, https://github.com/googlefonts/gf-docs/tree/master/Spec#fvar-instances.

For instance names, we only allow weight and italic particles. However, we expect these styles should be included in a STAT table.

If it still remains unclear, open an issue in the docs and we'll improve them.

@davelab6
Copy link
Member

davelab6 commented Jul 20, 2020 via email

@EwonRael
Copy link
Contributor

okay so the Bodoni Moda branch now static+variable fonts that pass all fontbakery tests and should conform to the instance naming/STAT policy.

Don't worry @davelab6 as long as we're pulling from the google branch or using the build-GF.sh script the family name is "Bodoni Moda"

Let me know how things look

@EwonRael
Copy link
Contributor

I'm thinking everything is good on my end to push to GF? Let me know if I'm mistaken about this or if there's something more I should be doing?

@davelab6
Copy link
Member

davelab6 commented Oct 1, 2020

Don't worry @davelab6 as long as we're pulling from the google branch or using the build-GF.sh script the family name is "Bodoni Moda"

Why isn't the full project called Bodoni Moda?

@EwonRael
Copy link
Contributor

EwonRael commented Oct 1, 2020

should I make a separate repo for Bodoni Moda naming convention?

@RosaWagner RosaWagner linked a pull request Oct 7, 2020 that will close this issue
@RosaWagner RosaWagner removed a link to a pull request Feb 26, 2021
@RosaWagner RosaWagner linked a pull request Feb 26, 2021 that will close this issue
@RosaWagner RosaWagner self-assigned this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants