Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodoni Moda: Version 2.3 added #2693

Closed
wants to merge 12 commits into from
Closed

Conversation

EwonRael
Copy link
Contributor

@RosaWagner
Copy link
Contributor

Thanks @EwonRael for the PR ! Bodoni was actually on my to-do list to onboard it on GF.

There are some STAT and naming issue. I would suggest to follow the process that we have in this repo which have an optical size axis, and adapt of course the gen_stat.py and the design space. This one doesn't have a weight axis so no fvar instances, but yours are well set with just the weight, just the master used as font origin can be called "BodoniModa-Regular" (and not "BodoniModa11-Regular") and the output path for the VF should be …/BodoniModa[opsz,wght].ttf. Same for the fvar instances of the VF: familily name= Bodoni Moda, style name= Bold. No point size.

Then, for the static instances, you can append the point size as you already do, but with "pt" appended like: BodoniModa11pt-Regular.ttf

2 separate VF for upright and italic is great. So no ital axis in the designspace, but definetely one set up in the STAT. Actually you can take this script or study Literata repo in general.

Tell me if something is unclear !

@RosaWagner RosaWagner added the -- Upstream is working on it Designer is making changes in the upstream repo label Sep 24, 2020
@EwonRael
Copy link
Contributor Author

Hey @RosaWagner thanks for looking things over. Glad to know that Bodoni Moda hasn't been forgotten.

The Ballet family is gorgeous. I couldn't find anything with a point size axis in production for reference so I'm glad you directed me towards that.

Happy to take the point size out of the variable builds name. Someone at some point I feel like told me to do that. I will have to go digging to figure out if that was the case.

I think everything looks clear to me. I will have to look it over more carefully when I have more time. I'd love to get more self-sufficient at this kind of thing. I love making fonts, but if I figure out how to do this kind of thing better maybe I can help play a more supportive role in other people's projects. That would be cool. Just if I could get more involved in general.

Maybe not the place to ask but how are things with the Jost? I tried to push changes. Not reflected on GF yet.

I'll get back to you

@RosaWagner
Copy link
Contributor

RosaWagner commented Sep 25, 2020

Happy to take the point size out of the variable builds name. Someone at some point I feel like told me to do that. I will have to go digging to figure out if that was the case.

For the statics the point size is supposed to be in the family name. But since the variable get all of them, no need to append it.

Maybe not the place to ask but how are things with the Jost? I tried to push changes. Not reflected on GF yet.

Jost is in sandbox so it should be in production next week if everything goes according to plan 👍

@RosaWagner
Copy link
Contributor

Please, also add some promotional pictures for GF twitter in your repo (in a "documentation" folder for example). We need 2-3 images with a nice twitter-friendly ratio. Video is also accepted.

@EwonRael
Copy link
Contributor Author

I updated the font files to incorporate the changes. Let me know if it looks good.

When I first announced Bodoni* at indestructible type* I made a little video for twitter. Would something like that be good (with Bodoni Moda not bodoni etc.)?

I think the little song is quite cute but maybe something without sound would be better?

Let me know!

filename: "BodoniModa-Italic[opsz,wght].ttf"
post_script_name: "BodoniModa11-Italic"
full_name: "Bodoni Moda Italic"
copyright: "Copyright 2020 The Bodoni Moda Project Authors (https:gitpro.ttaallkk.topindestructible-type)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the metadata file which shows that the regular is good, while the italic still have the wrong postscript name and a typo in the copyright URL (https://)

@RosaWagner
Copy link
Contributor

For the instances (fvar and exported statics), we also need SemiBold (600)

@EwonRael
Copy link
Contributor Author

I think I fixed all the metadata stuff in the italic. Weird that it lost all the "/"s in the copyright.

I can have it build a semibold... For some reason this feels in conflict with the artistic vision. Not the hill I want to die on. Are you also wanting an 800 weight?

@RosaWagner
Copy link
Contributor

RosaWagner commented Sep 28, 2020

For the semibold, @davelab6 will explain it better than me. We need to be able to cover a full range of weights between the 2 given extremes (fonttools/fontbakery#3031), so no need to add the 800. In GF API, the instances are generated from the variable font, and it will display a SemiBold in any case. We need the exported statics for the ttf hinting, if I understood correctly… so if the 600 is missing, then the statics are not so useful.

@EwonRael
Copy link
Contributor Author

I made the semibold and extrabold.

Let me know if everything looks good, and let me know about the music twitter question. I wrote that song and am quite proud of it.

@RosaWagner
Copy link
Contributor

@EwonRael can you also reexport the variable fonts with semibold and extrabold instances?

@RosaWagner
Copy link
Contributor

please also do gftools add-font ofl/bodonimoda to update metadata.pb

@RosaWagner
Copy link
Contributor

RosaWagner commented Sep 30, 2020

And the music is indeed lovely. Maybe a more squarish format would fit better.

@RosaWagner
Copy link
Contributor

There is still something wrong with the STAT table, and it is probably coming from your build script. You are using fix-vf-meta, statmake and the stat.py script.

  • fix-vf-meta > we use it for fonts with only one axis
  • statmake > we don't use it anymore

Post-process of your variable fonts should look like this:

echo "Hot Fixes for Variable Font"
vfs=$(ls ../fonts/variable/*.ttf)
for font in $vfs
do
	gftools fix-dsig --autofix $font
	gftools fix-nonhinting $font $font.fix #we dont hint new variable fonts
	mv $font.fix $font
	gftools fix-unwanted-tables --tables MVAR 
done
rm ../fonts/variable/*gasp*
python3 ../sources-GF/Designspace/stat.py

Fontbakery also report an issue with your GDEF table.

Make sure:

  • only the comb accents have anchors and 0-width
  • the accents (without comb in the name) don't have 0 width

@RosaWagner RosaWagner linked an issue Oct 7, 2020 that may be closed by this pull request
5 tasks
@EwonRael
Copy link
Contributor Author

EwonRael commented Oct 7, 2020

made fixes hopefully that's the last round

video up on repo

@RosaWagner RosaWagner self-assigned this Oct 19, 2020
@RosaWagner RosaWagner added In Progress and removed -- Upstream is working on it Designer is making changes in the upstream repo labels Nov 3, 2020
@RosaWagner
Copy link
Contributor

New PR : #2833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants