Expanded/Collapsed listeners #50
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -50,6 +50,25 @@ | |||
| private HoverMenuAdapter mAdapter; | |||
| private SharedPreferences mPrefs; | |||
| private Set<OnExitListener> mOnExitListeners = new HashSet<>(); | |||
| private Set<OnCollapseAndExpandListener> mOnCollapseAndExpandListeners = new HashSet<>(); | |||
There was a problem hiding this comment.
Can you change the implementation to a CopyOnWriteArraySet to avoid possible concurrency issues?
| @@ -45,6 +45,7 @@ | |||
| private boolean mIsShowingHoverMenu; // Are we currently display mHoverMenuView? | |||
| private boolean mIsInDragMode; // If we're not in drag mode then we're in menu mode. | |||
| private Set<OnExitListener> mOnExitListeners = new HashSet<>(); | |||
| private Set<OnCollapseAndExpandListener> mOnCollapseAndExpandListeners = new HashSet<>(); | |||
There was a problem hiding this comment.
Can you change the implementation to a CopyOnWriteArraySet to avoid possible concurrency issues?
| @@ -131,6 +150,7 @@ public void expandMenu() { | |||
|
|
|||
| @Override | |||
| public void collapseMenu() { | |||
| mHoverMenuView.setHoverMenuTransitionListener(mHoverMenuTransitionListener); | |||
|
I signed it as a Company a corporation, the company's name is: Ilhasoft. I'll make the proper changes and update PR. Thanks! |
|
anyone gonna merge this? |
This PR adds the Expanded/Collapsed listeners feature, described in README.md but not implemented.