This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Expanded/Collapsed listeners #50
Open
johncordeiro
wants to merge
5
commits into
google:master
Choose a base branch
from
Ilhasoft:feature/collapse-expand-listener
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1add5a0
Update build tools version to 23.0.3
johncordeiro f3be90f
Add expanded or collapsed listeners for callers
johncordeiro f00528e
Add callbacks on default service
johncordeiro 87dc662
Add logs to demo hover menu service as sample
johncordeiro 9e6a7e4
Remove unnecessary application tag
johncordeiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,25 @@ public class ViewHoverMenu extends FrameLayout implements HoverMenu { | |
private HoverMenuAdapter mAdapter; | ||
private SharedPreferences mPrefs; | ||
private Set<OnExitListener> mOnExitListeners = new HashSet<>(); | ||
private Set<OnCollapseAndExpandListener> mOnCollapseAndExpandListeners = new HashSet<>(); | ||
|
||
private HoverMenuView.HoverMenuTransitionListener mHoverMenuTransitionListener = new HoverMenuView.HoverMenuTransitionListener() { | ||
@Override | ||
public void onCollapsing() { } | ||
|
||
@Override | ||
public void onCollapsed() { | ||
notifyOnCollapsedListeners(); | ||
} | ||
|
||
@Override | ||
public void onExpanding() {} | ||
|
||
@Override | ||
public void onExpanded() { | ||
notifyOnExpandedListeners(); | ||
} | ||
}; | ||
|
||
public ViewHoverMenu(Context context) { | ||
this(context, null); | ||
|
@@ -131,6 +150,7 @@ public void expandMenu() { | |
|
||
@Override | ||
public void collapseMenu() { | ||
mHoverMenuView.setHoverMenuTransitionListener(mHoverMenuTransitionListener); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this for? |
||
mHoverMenuView.collapse(); | ||
} | ||
|
||
|
@@ -144,6 +164,28 @@ public void removeOnExitListener(@NonNull OnExitListener onExitListener) { | |
mOnExitListeners.remove(onExitListener); | ||
} | ||
|
||
@Override | ||
public void addOnCollapseAndExpandListener(@NonNull OnCollapseAndExpandListener onCollapseAndExpandListener) { | ||
mOnCollapseAndExpandListeners.add(onCollapseAndExpandListener); | ||
} | ||
|
||
@Override | ||
public void removeOnCollapseAndExpandListener(@NonNull OnCollapseAndExpandListener onCollapseAndExpandListener) { | ||
mOnCollapseAndExpandListeners.remove(onCollapseAndExpandListener); | ||
} | ||
|
||
private void notifyOnCollapsedListeners() { | ||
for (OnCollapseAndExpandListener listener : mOnCollapseAndExpandListeners) { | ||
listener.onHoverMenuCollapsed(); | ||
} | ||
} | ||
|
||
private void notifyOnExpandedListeners() { | ||
for (OnCollapseAndExpandListener listener : mOnCollapseAndExpandListeners) { | ||
listener.onHoverMenuExpanded(); | ||
} | ||
} | ||
|
||
private void notifyOnExitListeners() { | ||
for (OnExitListener listener : mOnExitListeners) { | ||
listener.onExitByUserRequest(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,7 @@ public class WindowHoverMenu implements HoverMenu { | |
private boolean mIsShowingHoverMenu; // Are we currently display mHoverMenuView? | ||
private boolean mIsInDragMode; // If we're not in drag mode then we're in menu mode. | ||
private Set<OnExitListener> mOnExitListeners = new HashSet<>(); | ||
private Set<OnCollapseAndExpandListener> mOnCollapseAndExpandListeners = new HashSet<>(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you change the implementation to a CopyOnWriteArraySet to avoid possible concurrency issues? |
||
|
||
private HoverMenuView.HoverMenuTransitionListener mHoverMenuTransitionListener = new HoverMenuView.HoverMenuTransitionListener() { | ||
@Override | ||
|
@@ -57,6 +58,7 @@ public void onCollapsed() { | |
// take over. We do this so that touch events outside the drag area can propagate to | ||
// applications on screen. | ||
mWindowViewController.makeUntouchable(mHoverMenuView); | ||
notifyOnCollapsedListeners(); | ||
} | ||
|
||
@Override | ||
|
@@ -67,6 +69,7 @@ public void onExpanding() { | |
@Override | ||
public void onExpanded() { | ||
mWindowViewController.makeTouchable(mHoverMenuView); | ||
notifyOnExpandedListeners(); | ||
} | ||
}; | ||
|
||
|
@@ -190,6 +193,28 @@ public void removeOnExitListener(@NonNull OnExitListener onExitListener) { | |
mOnExitListeners.remove(onExitListener); | ||
} | ||
|
||
@Override | ||
public void addOnCollapseAndExpandListener(@NonNull OnCollapseAndExpandListener onCollapseAndExpandListener) { | ||
mOnCollapseAndExpandListeners.add(onCollapseAndExpandListener); | ||
} | ||
|
||
@Override | ||
public void removeOnCollapseAndExpandListener(@NonNull OnCollapseAndExpandListener onCollapseAndExpandListener) { | ||
mOnCollapseAndExpandListeners.remove(onCollapseAndExpandListener); | ||
} | ||
|
||
private void notifyOnCollapsedListeners() { | ||
for (OnCollapseAndExpandListener listener : mOnCollapseAndExpandListeners) { | ||
listener.onHoverMenuCollapsed(); | ||
} | ||
} | ||
|
||
private void notifyOnExpandedListeners() { | ||
for (OnCollapseAndExpandListener listener : mOnCollapseAndExpandListeners) { | ||
listener.onHoverMenuExpanded(); | ||
} | ||
} | ||
|
||
private void notifyOnExitListeners() { | ||
for (OnExitListener listener : mOnExitListeners) { | ||
listener.onExitByUserRequest(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the implementation to a CopyOnWriteArraySet to avoid possible concurrency issues?