Upgrade to latest threejs (r164) #4787
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -446,7 +446,7 @@ configuration or device capabilities'); | |||
| model.position.copy(target.position); | |||
| model.updateWorldMatrix(false, true); | |||
|
|
|||
| const arraybuffer = await exporter.parse(model); | |||
| const arraybuffer = await exporter.parseAsync(model); | |||
There was a problem hiding this comment.
Actually, I believe there's another exporter.parse in scene-graph.ts as well - could you update that as well for consistency?
There was a problem hiding this comment.
Yes, I'll take a look.
There was a problem hiding this comment.
@elalish I don't believe the call in scene-graph.ts needs to be altered as it's using the callback-based version of parse. parse previously used to support both a callback and Promise-based overload, but now the asynchronous version is called parseAsync. ar.ts await-ed the return, so it needed to be adjusted to use the new async version, but the call to parse in scene-graph.ts is callback-based.
Reference Issue
Fixes #4786