Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZExporter: Rename parse to parseAsync #28049

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

mjurczyk
Copy link
Contributor

@mjurczyk mjurczyk commented Apr 2, 2024

Related issue: #28050

Description

Adjust naming consistency for USDZExporter

USDZExporter: Add parse method
Examples: Update misc_exporter_usdz
Editor: Replace USDZExporter.parse with parseAsync
@Mugen87 Mugen87 added this to the r164 milestone Apr 2, 2024
@mrdoob mrdoob merged commit 49d26cc into mrdoob:dev Apr 3, 2024
11 checks passed
@mjurczyk mjurczyk deleted the usdz-exporter-parse-async branch April 3, 2024 09:25
@mrdoob
Copy link
Owner

mrdoob commented Apr 25, 2024

FYI @elalish

aardvarkk added a commit to aardvarkk/model-viewer that referenced this pull request May 21, 2024
elalish pushed a commit to google/model-viewer that referenced this pull request May 29, 2024
* Upgrade to latest threejs (r164)

* `parse` was renamed to `parseAsync`

- mrdoob/three.js#28049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants