Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change spanner::RouteToLeaderOption to be on by default #11111

Closed
devbww opened this issue Mar 27, 2023 · 1 comment · Fixed by #12319
Closed

change spanner::RouteToLeaderOption to be on by default #11111

devbww opened this issue Mar 27, 2023 · 1 comment · Fixed by #12319
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@devbww
Copy link
Contributor

devbww commented Mar 27, 2023

We have received the go-ahead to release the spanner::RouteToLeaderOption feature, but as "off by default".

Users can override this programmatically with opts.set<spanner::RouteToLeaderOption>(true), or environmentally with GOOGLE_CLOUD_CPP_SPANNER_ROUTE_TO_LEADER=1.

This issue is for changing that back to "on by default" when the time is right.
@devbww devbww added type: cleanup An internal cleanup or hygiene concern. api: spanner Issues related to the Spanner API. labels Mar 27, 2023
devbww added a commit to devbww/google-cloud-cpp that referenced this issue Mar 27, 2023
@devbww
feat(spanner): add the final pieces for the RouteToLeaderOption
99d1262 
The final glue to add a routing header to Spanner RPCs that should be
served in the leader region.

For the time being, the boolean option defaults to off (set as false),
but that default can be changed with a suitably-positive value for
`${GOOGLE_CLOUD_CPP_SPANNER_ROUTE_TO_LEADER}`.  The conditional code
can be removed to restore the defaults-to-on behavior.  See googleapis#11111.
@devbww devbww mentioned this issue Mar 27, 2023
Merged
devbww added a commit that referenced this issue Mar 28, 2023
@devbww
feat(spanner): add the final pieces for the RouteToLeaderOption (#11112)
bedd265 
The final glue to add a routing header to Spanner RPCs that should be
served in the leader region.

For the time being, the boolean option defaults to off (set as false).  See
#11111.

`${GOOGLE_CLOUD_CPP_SPANNER_ROUTE_TO_LEADER}` overrides any
code setting for the `RouteToLeaderOption`.
@coryan
Copy link
Contributor

coryan commented Jul 19, 2023

Still waiting for the service team to say it is Okay to do this.

devbww added a commit to devbww/google-cloud-cpp that referenced this issue Aug 4, 2023
@devbww
feat(spanner): enable leader aware routing by default
8ebd5d5 
I've been told to include this text in the PR description:

"This update contains performance optimisations that will reduce the
latency of read/write transactions that originate from a region other
than the default leader region."

See googleapis#11112.  Fixes googleapis#11111.
@devbww devbww mentioned this issue Aug 4, 2023
Merged
devbww added a commit that referenced this issue Aug 4, 2023
@devbww
feat(spanner): enable leader aware routing by default (#12319)
4dda714 
I've been told to include this text in the PR description:

"This update contains performance optimisations that will reduce the
latency of read/write transactions that originate from a region other
than the default leader region."

See #11112.  Fixes #11111.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner): enable leader aware routing by default devbww/google-cloud-cpp
2 participants
@coryan @devbww