feat(spanner): enable leader aware routing by default #12319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been told to include this text in the PR description: "This update contains performance optimisations that will reduce the latency of read/write transactions that originate from a region other than the default leader region." See googleapis#11112. Fixes googleapis#11111.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12319 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2017 2017
Lines 178384 178380 -4
=======================================
- Hits 166863 166860 -3
+ Misses 11521 11520 -1
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Aug 4, 2023
| // The option defaults to on (unset), but the default can be changed with a | ||
| // suitably-negative value in `${GOOGLE_CLOUD_CPP_SPANNER_ROUTE_TO_LEADER}`. | ||
| if (auto e = internal::GetEnv("GOOGLE_CLOUD_CPP_SPANNER_ROUTE_TO_LEADER")) { | ||
| for (auto const* disable : {"N", "n", "F", "f", "0", "off"}) { |
There was a problem hiding this comment.
Is it me, or we have used this sequence of values elsewhere? Should we have a function? And why not OFF, since we have N and n?
Neither of those questions is blockin.
There was a problem hiding this comment.
Yes, we have ParseBoolean() in google/cloud/tracing_options.cc, which we could probably try to common-ize now.
As for the values, I just stuck with the ParseBoolean() choices, so that refactoring was a possibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been told to include this text in the PR description:
"This update contains performance optimisations that will reduce the latency of read/write transactions that originate from a region other than the default leader region."
See #11112. Fixes #11111.
This change is