Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support external accounts in GoogleDefaultCredentials() #10430

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 13, 2022

Part of the work for #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 9a13255a70c8cfcba8c7c96dd3ca9bbe07b938b2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 93.88% // Head: 93.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5a376be) compared to base (acb4355).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10430   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files        1610     1610           
  Lines      146096   146183   +87     
=======================================
+ Hits       137163   137249   +86     
- Misses       8933     8934    +1     
Impacted Files Coverage Δ
google/cloud/internal/oauth2_google_credentials.cc 92.18% <100.00%> (+0.95%) ⬆️
...e/cloud/internal/oauth2_google_credentials_test.cc 99.38% <100.00%> (+0.19%) ⬆️
...le/cloud/internal/unified_rest_credentials_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.99% <0.00%> (-0.67%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 100.00% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@coryan coryan marked this pull request as ready for review December 13, 2022 17:33
@coryan coryan requested a review from a team as a code owner December 13, 2022 17:33
@coryan coryan force-pushed the feat-oauth2-workload-identity-federation-pr20 branch from 9a13255 to 5a376be Compare December 13, 2022 18:11
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5a376bebb0f376a5d48f77ca2c394c63e7651fcf

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) December 13, 2022 18:28
@coryan coryan merged commit 80e686d into googleapis:main Dec 13, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr20 branch December 13, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants