fix: retries for GetIamPolicy, TestIamPermissions #10957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.64% // Head: 93.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10957 +/- ##
==========================================
- Coverage 93.64% 93.64% -0.01%
==========================================
Files 1717 1717
Lines 154915 154918 +3
==========================================
+ Hits 145070 145072 +2
- Misses 9845 9846 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
devbww
approved these changes
Feb 26, 2023
coryan
reviewed
Feb 27, 2023
| @@ -430,6 +430,10 @@ void SetHttpGetQueryParameters( | |||
|
|
|||
| std::string DefaultIdempotencyFromHttpOperation( | |||
| google::protobuf::MethodDescriptor const& method) { | |||
| if (method.name() == "GetIamPolicy" || | |||
There was a problem hiding this comment.
nit: there is prior code to detect SetIamPolicy methods, maybe you should have followed the same structure as those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #10413
It seemed better to add a special case to the generator's default idempotency method than to maintain the configuration in
generator_config.textprotoforNservices. And theN+1th service will have the proper defaults for the IAM methods without manual intervention.This change is