Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): stricter IAM checks #10965

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 27, 2023

@coryan says "there is prior code to detect SetIamPolicy methods, maybe you should have followed the same structure as those?" #10957 (comment)

I think this is what he means.


This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 93.64% // Head: 93.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c01d6c0) compared to base (c7e5d7c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10965   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1716     1716           
  Lines      154882   154890    +8     
=======================================
+ Hits       145042   145050    +8     
  Misses       9840     9840           
Impacted Files Coverage Δ
generator/internal/descriptor_utils.cc 89.62% <100.00%> (+0.10%) ⬆️
generator/internal/descriptor_utils_test.cc 99.01% <100.00%> (+<0.01%) ⬆️
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 27, 2023 22:29
@dbolduc dbolduc requested a review from a team as a code owner February 27, 2023 22:29
@dbolduc dbolduc enabled auto-merge (squash) February 27, 2023 22:43
@dbolduc dbolduc merged commit 81d2106 into googleapis:main Feb 27, 2023
@dbolduc dbolduc deleted the stricter-iam-idempotency branch February 27, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants