Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(otel): trace context across AsyncPollingLoop #11040

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 14, 2023

Part of the work for #10618

Propagate trace context across an Async(Rest)PollingLoop


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review March 14, 2023 22:00
@dbolduc dbolduc requested a review from a team as a code owner March 14, 2023 22:00
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f81ff8b) 93.75% compared to head (a9807ff) 93.76%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11040    +/-   ##
========================================
  Coverage   93.75%   93.76%            
========================================
  Files        1725     1725            
  Lines      155440   155535    +95     
========================================
+ Hits       145739   145839   +100     
+ Misses       9701     9696     -5     
Impacted Files Coverage Δ
google/cloud/internal/async_polling_loop.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_polling_loop_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_rest_polling_loop.cc 100.00% <100.00%> (ø)
...gle/cloud/internal/async_rest_polling_loop_test.cc 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc merged commit acb3ffc into googleapis:main Mar 15, 2023
@dbolduc dbolduc deleted the call-context-pr-2 branch November 16, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants