Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async OpenTelemetry tracing in common/grpc_utils #10618

Closed
5 tasks done
dbolduc opened this issue Jan 19, 2023 · 0 comments · Fixed by #11056
Closed
5 tasks done

Async OpenTelemetry tracing in common/grpc_utils #10618

dbolduc opened this issue Jan 19, 2023 · 0 comments · Fixed by #11056
Assignees
Labels
cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dbolduc
Copy link
Member

dbolduc commented Jan 19, 2023

Some tasks from Milestone 2 of an internal design doc. With these tasks completed, we can support tracing an asynchronous gRPC client call.

  • Implement EndSpan(...) for future<> types.
  • Use shared_ptr<grpc::ClientContext> basically everywhere that has unique_ptr<grpc::ClientContext>
  • Use CallContext instead of OptionsSpan. These are mainly in AsyncGrpcOperations.
  • Add traced async backoff; update (Rest)Async{Retry,Polling}Loop to use it
  • Add SetAttribute; Update AsyncPollingLoop to set LRO name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant