impl(otel): trace captures LRO name #11056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11056 +/- ##
=======================================
Coverage 93.74% 93.75%
=======================================
Files 1727 1727
Lines 155822 155889 +67
=======================================
+ Hits 146081 146156 +75
+ Misses 9741 9733 -8
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
devbww
reviewed
Mar 17, 2023
dbolduc
force-pushed
the
otel-add-span-attribute
branch
from
4d7317b
to
985901b
Compare
devbww
approved these changes
Mar 18, 2023
grace223
reviewed
Mar 18, 2023
| using ::google::cloud::testing_util::SpanNamed; | ||
| using ::testing::AllOf; | ||
| using ::testing::Each; | ||
| using ::testing::SizeIs; | ||
|
|
||
| TEST(AsyncPollingLoopTest, TracedAsyncBackoff) { |
| @@ -317,6 +317,39 @@ TEST(OpenTelemetry, MakeTracedSleeperDisabled) { | |||
| EXPECT_THAT(spans, IsEmpty()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10618
Note that, at the moment, I only need to set one string attribute. I may want a more general interface (set numeric attributes, set multiple attributes at once). But I am not going to generalize until the need is clear.
This change is