Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(otel): traced async backoff in retry loop #11051

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 16, 2023

Part of the work for #10618


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fa66623) 93.75% compared to head (86850a4) 93.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11051   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files        1727     1727           
  Lines      155723   155745   +22     
=======================================
+ Hits       145997   146021   +24     
+ Misses       9726     9724    -2     
Impacted Files Coverage Δ
google/cloud/internal/async_rest_retry_loop.h 100.00% <100.00%> (ø)
...oogle/cloud/internal/async_rest_retry_loop_test.cc 99.24% <100.00%> (+0.02%) ⬆️
google/cloud/internal/async_retry_loop.h 100.00% <100.00%> (ø)
google/cloud/internal/async_retry_loop_test.cc 99.49% <100.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review March 16, 2023 19:11
@dbolduc dbolduc requested a review from a team as a code owner March 16, 2023 19:11
@dbolduc dbolduc merged commit fcd6cab into googleapis:main Mar 16, 2023
@dbolduc dbolduc deleted the otel-async-retry-loop-tracing branch March 16, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants