Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid development dependencies with Bazel #11724

Merged
merged 2 commits into from
May 24, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 24, 2023

This change is Reviewable

@@ -17,8 +17,63 @@
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

def google_cloud_cpp_development_deps(name = None):
"""Loads dependencies need to develop the google-cloud-cpp libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/need/needed/


google-cloud-cpp developers call this function from the top-level WORKSPACE
file to obtain all the necessary *development* dependencies for
google-cloud-cpp, this includes testing dependencies and dependencies used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, this/. This/

google-cloud-cpp, this includes testing dependencies and dependencies used
by development tools.

While primarily intended for google-cloud-cpp developers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@@ -66,7 +121,8 @@ def google_cloud_cpp_deps(name = None):
strip_prefix = "abseil-cpp-20230125.3",
)

# Load a version of googletest that we know works.
# Load a version of googletest that we know works. This is needed to create
# google_cloud_cpp_*_mocks libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: //:*_mocks instead of google_cloud_cpp_*_mocks ?

(and we just pretend that //:mocks matches the regex)

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@375faf7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11724   +/-   ##
=======================================
  Coverage        ?   93.78%           
=======================================
  Files           ?     1829           
  Lines           ?   164882           
  Branches        ?        0           
=======================================
  Hits            ?   154631           
  Misses          ?    10251           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review May 24, 2023 22:42
@coryan coryan requested a review from a team as a code owner May 24, 2023 22:42
@coryan coryan enabled auto-merge (squash) May 24, 2023 22:42
@coryan coryan merged commit 73bab5d into googleapis:main May 24, 2023
@coryan coryan deleted the cleanup-avoid-development-dependencies branch May 24, 2023 23:36
devbww added a commit to devbww/google-cloud-cpp that referenced this pull request Jul 5, 2023
Adapt to the new shape of google_cloud_cpp_deps.bzl, where googleapis#11724
introduced an additional `maybe()` calling function.
devbww added a commit that referenced this pull request Jul 5, 2023
…2017)

Adapt to the new shape of google_cloud_cpp_deps.bzl, where #11724
introduced an additional `maybe()` calling function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants