Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): adapt deps-cache.py to new google_cloud_cpp_deps.bzl #12017

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Jul 5, 2023

Adapt to the new shape of google_cloud_cpp_deps.bzl, where #11724 introduced an additional maybe() calling function.


This change is Reviewable

Adapt to the new shape of google_cloud_cpp_deps.bzl, where googleapis#11724
introduced an additional `maybe()` calling function.
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5ee7b7c) 93.67% compared to head (76b92ac) 93.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12017      +/-   ##
==========================================
- Coverage   93.67%   93.67%   -0.01%     
==========================================
  Files        1838     1838              
  Lines      166829   166829              
==========================================
- Hits       156272   156270       -2     
- Misses      10557    10559       +2     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww marked this pull request as ready for review July 5, 2023 05:26
@devbww devbww requested a review from a team as a code owner July 5, 2023 05:26
@devbww devbww merged commit bfe5ef7 into googleapis:main Jul 5, 2023
44 checks passed
@devbww devbww deleted the deps-cache branch July 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants