feat(oauth2): new library to create oauth2 tokens #12064
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #12064 +/- ##
==========================================
- Coverage 93.69% 93.68% -0.01%
==========================================
Files 2012 2012
Lines 175674 175674
==========================================
- Hits 164599 164588 -11
- Misses 11075 11086 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
If we anticipate more public OAuth2 files/classes, should we consider adding a google/cloud/oauth2 directory for these to live in, as opposed to google/cloud?
Reviewable status: 0 of 14 files reviewed, all discussions resolved
coryan
force-pushed
the
feat-introduce-access-token-generator
branch
from
dc9a3a6
to
d081031
Compare
There was a problem hiding this comment.
I am thinking about it. Sounds like a good idea. Let me do some other refactoring first and maybe discuss in the meeting tomorrow (won't merge until after that discussion).
Reviewed 11 of 13 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @devbww)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @coryan)
coryan
force-pushed
the
feat-introduce-access-token-generator
branch
from
d081031
to
a4cc218
Compare
There was a problem hiding this comment.
I moved the code to google/cloud/oauth2. Let's discuss today.
Reviewed 11 of 11 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devbww)
This is basically a wrapper around some classes in the
rest_internallibrary. We need a new library because applications should not linkrest_internal: all libraries withinternalin their name are not part of the public API.Fixes #11920
This change is