Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: const-correctness for unified credentials #12073

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 12, 2023

When mapping google::cloud::Credentials to the implementation (gRPC or REST) we don't need a std::shared_ptr<> or (shudder) std::shared_ptr<> const&. The visitor can work with a const&.

Motivated by #12064 (comment)


This change is Reviewable

When mapping `google::cloud::Credentials` to the implementation (gRPC or
REST) we don't need a `std::shared_ptr<>` or (shudder)
`std::shared_ptr<> const&`.  The visitor can work with a `const&`.
@coryan coryan marked this pull request as ready for review July 12, 2023 01:14
@coryan coryan requested a review from a team as a code owner July 12, 2023 01:14
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 94.91% and project coverage change: -0.01 ⚠️

Comparison is base (57acdc1) 93.68% compared to head (e8dcee7) 93.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12073      +/-   ##
==========================================
- Coverage   93.68%   93.68%   -0.01%     
==========================================
  Files        2012     2012              
  Lines      175425   175425              
==========================================
- Hits       164347   164342       -5     
- Misses      11078    11083       +5     
Impacted Files Coverage Δ
google/cloud/internal/unified_grpc_credentials.h 100.00% <ø> (ø)
...cloud/storage/internal/unified_rest_credentials.cc 78.57% <85.71%> (ø)
google/cloud/internal/unified_grpc_credentials.cc 82.97% <87.50%> (ø)
google/cloud/internal/unified_rest_credentials.cc 94.91% <87.50%> (-1.70%) ⬇️
google/cloud/internal/credentials_impl.cc 100.00% <100.00%> (ø)
google/cloud/internal/credentials_impl.h 100.00% <100.00%> (ø)
google/cloud/internal/credentials_impl_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/curl_rest_client.cc 96.35% <100.00%> (ø)
...cloud/internal/grpc_impersonate_service_account.cc 100.00% <100.00%> (ø)
.../oauth2_impersonate_service_account_credentials.cc 100.00% <100.00%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan enabled auto-merge (squash) July 12, 2023 12:17
@coryan coryan merged commit 60a52cb into googleapis:main Jul 12, 2023
45 checks passed
@coryan coryan deleted the cleanup-map-credentials-argument-type branch July 12, 2023 15:38
@googleapis googleapis deleted a comment Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants