Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE #12911

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE #12911

merged 3 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE 

    Enabling `oauth2` if `GOOGLE_CLOUD_CPPP_ENABLE_REST` is set is a bug: it
introduces a cycle in the dependencies of the library, and makes it
impossible to compile `oauth2`, `storage`, and `compute` in different
shards.
    @coryan
    coryan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d9ebedd View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @coryan
    coryan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d1fee32 View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @coryan
    coryan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    76d4807 View commit details
    Browse the repository at this point in the history