Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE #12911

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 16, 2023

Enabling oauth2 if GOOGLE_CLOUD_CPPP_ENABLE_REST is set is a bug: it introduces a cycle in the dependencies of the library, and makes it impossible to compile oauth2, storage, and compute in different shards.


This change is Reviewable

@coryan coryan temporarily deployed to internal October 16, 2023 22:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fa4eeb6) 93.61% compared to head (76d4807) 93.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12911      +/-   ##
==========================================
- Coverage   93.61%   93.61%   -0.01%     
==========================================
  Files        2067     2067              
  Lines      180057   180057              
==========================================
- Hits       168559   168558       -1     
- Misses      11498    11499       +1     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc
Copy link
Member

dbolduc commented Oct 17, 2023

makes it impossible to compile oauth2, storage, and compute in different shards.

Ah. Ok, I see the motivation now. I am OK calling this a bug.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR might deserve some words in the CHANGELOG.

Customers building storage and using oauth2::MakeAccessTokenGenerator(...) might need to update their code.

Enabling `oauth2` if `GOOGLE_CLOUD_CPPP_ENABLE_REST` is set is a bug: it
introduces a cycle in the dependencies of the library, and makes it
impossible to compile `oauth2`, `storage`, and `compute` in different
shards.
@coryan coryan force-pushed the fix-oauth2-do-not-enable-if-rest-is branch from 9dc2643 to d1fee32 Compare October 17, 2023 12:33
@coryan coryan temporarily deployed to internal October 17, 2023 12:33 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review October 17, 2023 12:33
@coryan coryan requested a review from a team as a code owner October 17, 2023 12:33
@coryan coryan enabled auto-merge (squash) October 17, 2023 12:34
@coryan coryan temporarily deployed to internal October 17, 2023 12:57 — with GitHub Actions Inactive
@coryan coryan merged commit 56fe3c6 into googleapis:main Oct 17, 2023
54 of 55 checks passed
@coryan coryan deleted the fix-oauth2-do-not-enable-if-rest-is branch October 17, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants