Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): easier mocks for *AccessControl #9910

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 23, 2022

Add modifiers for all the attributes in ObjectAccessControl and BucketAccessControl. That makes it easier to mock the class.

I deprecated internal::AccessControlCommon as this class is no longer used.

Part of the work for #8929


This change is Reviewable

Add modifiers for all the attributes in `ObjectAccessControl` and
`BucketAccessControl`. That makes it easier to mock the class.

I deprecated `internal::AccessControlCommon` as this class is no longer
used.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 23, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5a3bf9c558213914601c5a3bead1954eac26076c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 94.20% // Head: 94.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (810d82d) compared to base (f27d67f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #9910    +/-   ##
========================================
  Coverage   94.20%   94.20%            
========================================
  Files        1495     1495            
  Lines      140166   140285   +119     
========================================
+ Hits       132043   132157   +114     
- Misses       8123     8128     +5     
Impacted Files Coverage Δ
...d/storage/internal/access_control_common_parser.cc 72.72% <ø> (-22.73%) ⬇️
...rage/internal/access_control_common_parser_test.cc 100.00% <ø> (ø)
...ogle/cloud/storage/internal/object_acl_requests.cc 95.52% <ø> (ø)
google/cloud/storage/bucket_access_control.cc 100.00% <100.00%> (ø)
google/cloud/storage/bucket_access_control.h 100.00% <100.00%> (ø)
...gle/cloud/storage/internal/access_control_common.h 100.00% <100.00%> (ø)
...oud/storage/internal/access_control_common_test.cc 100.00% <100.00%> (ø)
...d/storage/internal/bucket_access_control_parser.cc 100.00% <100.00%> (+7.69%) ⬆️
...rage/internal/grpc_bucket_access_control_parser.cc 97.05% <100.00%> (-0.17%) ⬇️
...rage/internal/grpc_object_access_control_parser.cc 97.22% <100.00%> (-0.15%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 810d82deced04e58537021e3ff654d8482559238

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review September 23, 2022 20:49
@coryan coryan requested a review from a team as a code owner September 23, 2022 20:49
@coryan coryan merged commit 4c8cf6e into googleapis:main Sep 23, 2022
@coryan coryan deleted the feat-storage-easier-mocks-for-AccessControl branch September 23, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants