feat(storage): faster InsertObject() uploads
#9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the client library will only validate message boundaries for `InsertObject()` **only** if requested. The new default makes sense as (1) it saves about 2ms of client CPU time for 128MiB uploads, (2) if there is a collision this will be detected by the service via the upload checksums, and (3) the probability of a collision is small. The current implementation has a population of more than $$10^100$$ strings to pick from. The probability of finding this string in a EB of data is less than $$1 / 10^95$$. You could upload a EB of data per second for a billion years and still not find a collision.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
dbolduc
reviewed
Oct 7, 2022
Codecov ReportBase: 94.22% // Head: 94.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9997 +/- ##
=======================================
Coverage 94.22% 94.23%
=======================================
Files 1501 1501
Lines 141086 141085 -1
=======================================
+ Hits 132943 132948 +5
+ Misses 8143 8137 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
reviewed
Oct 7, 2022
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the client library will optimistically use a randomly generated string as a message boundary, but will not validate if the string appears in the payload.
The new behavior makes sense as (1) it saves about 2ms of client CPU time for 128MiB uploads, (2) if there is a collision this will be detected by the service via the upload checksums, and (3) the probability of a collision is small.
The current implementation has a population of more than$10^{100}$ strings to pick from. The probability of finding this string in a EB of data is less than $1 / 10^{95}$ . You could upload a EB of data per second for a billion years and still not find a collision.
This change is