Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): faster InsertObject() uploads #9997

Merged
merged 3 commits into from
Oct 7, 2022
Merged

feat(storage): faster InsertObject() uploads #9997

merged 3 commits into from
Oct 7, 2022

Commits on Oct 7, 2022

  1. feat(storage): faster InsertObject() uploads 

    With this change the client library will only validate message
boundaries for `InsertObject()` **only** if requested. The
new default makes sense as (1) it saves about 2ms of client
CPU time for 128MiB uploads, (2) if there is a collision this will be
detected by the service via the upload checksums, and (3) the
probability of a collision is small. The current implementation has
a population of more than $$10^100$$ strings to pick from. The
probability of finding this string in a EB of data is less than
$$1 / 10^95$$.  You could upload a EB of data per second for a billion
years and still not find a collision.
    @coryan
    coryan committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    cc0033a View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @coryan
    coryan committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e77232c View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @coryan
    coryan committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    ef7b242 View commit details
    Browse the repository at this point in the history