Data-driven V4 URL signing tests, and implementation changes #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
reviewed
Feb 19, 2019
| @@ -109,7 +109,8 @@ private struct SigningState | |||
| string expiryText = expirySeconds.ToString(CultureInfo.InvariantCulture); | |||
|
|
|||
| string clientEmail = blobSigner.Id; | |||
| string credentialScope = $"{datestamp}/auto/gcs/goog4_request"; | |||
| // TODO: This storage used to be gcs. Check it! | |||
| string credentialScope = $"{datestamp}/auto/storage/goog4_request"; | |||
There was a problem hiding this comment.
LGTM. Following gsutil implementation of "storage".
| "datestamp": "20190201", | ||
| "region": "auto", | ||
| "credentialScope": "20190201/auto/storage/goog4_request", | ||
| "expectedUrl": "https://storage.googleapis.com/test-bucket/test-object?x-goog-algorithm=GOOG4-RSA-SHA256&x-goog-credential=test-iam-credentials%40dummy-project-id.iam.gserviceaccount.com%2F20190201%2Fauto%2Fstorage%2Fgoog4_request&x-goog-date=20190201T090000Z&x-goog-expires=10&x-goog-signedheaders=host&x-goog-signature=95e6a13d43a1d1962e667f17397f2b80ac9bdd1669210d5e08e0135df9dff4e56113485dbe429ca2266487b9d1796ebdee2d7cf682a6ef3bb9fbb4c351686fba90d7b621cf1c4eb1fdf126460dd25fa0837dfdde0a9fd98662ce60844c458448fb2b352c203d9969cb74efa4bdb742287744a4f2308afa4af0e0773f55e32e92973619249214b97283b2daa14195244444e33f938138d1e5f561088ce8011f4986dda33a556412594db7c12fc40e1ff3f1bedeb7a42f5bcda0b9567f17f65855f65071fabb88ea12371877f3f77f10e1466fff6ff6973b74a933322ff0949ce357e20abe96c3dd5cfab42c9c83e740a4d32b9e11e146f0eb3404d2e975896f74" |
There was a problem hiding this comment.
Query parameter name casing discussion should be reopened. I comment on the bug and in the document related to this PR internally.
jskeet
force-pushed
the
signing-tests
branch
from
91c1c3e
to
1163f27
Compare
jskeet
added
needs work
Initially the test description is in our repo, but is likely to be somewhere common in the future.
It turns out we hardly need any of the V2 code in V4, so most of that has been moved into V2Signer.cs. All we need is the trimming part.
A fix for this is working its way through to production
jskeet
changed the title
|
Ready for review now :) This doesn't quite complete the V4 work - and I want to add more data-driven tests afterwards - but it's getting there. I'm rerunning all integration tests and snippets locally. |
amanda-tarafa
approved these changes
Mar 4, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The test fails at the moment, but I'm creating the PR for sharing purposes.)