Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-driven V4 URL signing tests, and implementation changes #2882

Merged
merged 4 commits into from
Mar 4, 2019
Merged

Data-driven V4 URL signing tests, and implementation changes #2882

merged 4 commits into from
Mar 4, 2019

Commits on Mar 4, 2019

  1. Introduce data-driven V4 URL signing tests 

    Initially the test description is in our repo, but is likely to be somewhere common in the future.
    @jskeet
    jskeet committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    c9b23db View commit details
    Browse the repository at this point in the history

  2. Rename fields within private state of V2 signer to follow our naming … 

    …conventions
    @jskeet
    jskeet committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    72ebcfe View commit details
    Browse the repository at this point in the history

  3. Implement header signing for V4 

    It turns out we hardly need any of the V2 code in V4, so most of that has been moved into V2Signer.cs. All we need is the trimming part.
    @jskeet
    jskeet committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    00f6cd2 View commit details
    Browse the repository at this point in the history

  4. Skip the V4 signing bucket fetch test temporarily 

    A fix for this is working its way through to production
    @jskeet
    jskeet committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    a3e0a3d View commit details
    Browse the repository at this point in the history