Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OpenTelemetry support for Subscribe Side #1252

Merged
merged 56 commits into from
Sep 24, 2024
Merged

feat: Add OpenTelemetry support for Subscribe Side #1252

merged 56 commits into from
Sep 24, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Sep 16, 2024 •
edited
Loading

Subscribe Side OpenTelemetry Code

@mukund-ananthu mukund-ananthu requested review from a team as code owners September 16, 2024 20:42
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Sep 16, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium. size: l Pull request size is large. and removed size: s Pull request size is small. size: m Pull request size is medium. labels Sep 16, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: l Pull request size is large. size: m Pull request size is medium. labels Sep 18, 2024
@mukund-ananthu mukund-ananthu force-pushed the otel_subscribe_feature branch 2 times, most recently from 6deb637 to 1703dd2 Compare September 18, 2024 19:29
@mukund-ananthu
Add SubscriberOptions and OpenTelemetry Subscriber option
04c3881
@mukund-ananthu
Set / Override OpenTelemetry Subscriber settings based on Python Version
0a679a5
@mukund-ananthu
Add OpenTelemetryContextGetter used for trace propagation
40a2996
@mukund-ananthu
Add Subscribe Span and SubscribeOpenTelemetry class
b10f2f6
@mukund-ananthu
Add receipt modack start and end events to subscribe span
95a1d32
@mukund-ananthu
Modify SubscriberMessage to include opentelemetry data and include
c556f99 
SubscribeSpan information in the SubscriberMessage's Open Telemetry data
@mukund-ananthu
Add ack, modack, nack start events to subscribe span
f52fbac
@mukund-ananthu
Add Open Telemetry data to Ack, Modack, Nack request objects
b5ab6bb 
* This is required for the Open Telemetry information to be percolated
  to the dispatcher which performs acks, nacks and modacks async.
* The Open Telemetry data passed into the dispatcher will be used to add
  events such as ack, modack, nack end to the subscribe span
@mukund-ananthu
Add ack result, ack end event to subscribe span and end it
a695c99
@mukund-ananthu
Add tests for ack and ack_with_response methods of Subscriber Message
694cfde 
* Both these methods should add the "ack start" event to the subscribe
  span
@mukund-ananthu
Add tests for nack and nack_with_response methods of Subscriber Message
27edc0f 
* Both these methods should add "nack start" events to the subscribe
  span
@mukund-ananthu
Add tests for modify_ack_deadline and modify_ack_deadline_with_response
c1f0ad8 
* Both these methods should add the "modack start" event to the
  subscribe span
@mukund-ananthu
Add nack span for dispatcher._retry_modacks
c8c5eb9
@mukund-ananthu
Fix modacks
6ec7c35 
* Currently, subscribe_span is ended after modack end event is added to
  the subscribe_span. This should not happen, since subscribe_span
  should be ended only after ack,nack or drop, but not modack
* Remove an extraneous modack start that was present in
  streaming_pull_manager.send_lease_modacks(). This is not required,
  since modack start and end events will anyways be added to the
  subscribe span in the dispatcher.modify_ack_deadline() method.
* Replace the NamedTuple._replace() methods with creation of new
  NamedTuple ModackRequest items. This is because NamedTuple._replace()
  returns a new NamedTuple, rather than replacing the existing one. This
  results in the opentelemetry data not being plumbed down into the
  dispatcher.modify_ack_deadline_method.
@mukund-ananthu
Fix mypy errors
7936911
@mukund-ananthu
Copy link
Contributor Author

@hongalex PTAL

@mukund-ananthu
Copy link
Contributor Author

@parthea PTAL

@mukund-ananthu mukund-ananthu merged commit 1b6f3d2 into main Sep 24, 2024
26 of 27 checks passed
@mukund-ananthu mukund-ananthu deleted the otel_subscribe_feature branch September 24, 2024 22:54
@release-please release-please bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukund-ananthu @hongalex