Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenTelemetry support for Subscribe Side #1252

Merged
merged 56 commits into from
Sep 24, 2024

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    04c3881 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a679a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40a2996 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b10f2f6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    95a1d32 View commit details
    Browse the repository at this point in the history
  6. Modify SubscriberMessage to include opentelemetry data and include

    SubscribeSpan information in the SubscriberMessage's Open Telemetry data
    mukund-ananthu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c556f99 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f52fbac View commit details
    Browse the repository at this point in the history
  8. Add Open Telemetry data to Ack, Modack, Nack request objects

    * This is required for the Open Telemetry information to be percolated
      to the dispatcher which performs acks, nacks and modacks async.
    * The Open Telemetry data passed into the dispatcher will be used to add
      events such as ack, modack, nack end to the subscribe span
    mukund-ananthu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b5ab6bb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a695c99 View commit details
    Browse the repository at this point in the history
  10. Add tests for ack and ack_with_response methods of Subscriber Message

    * Both these methods should add the "ack start" event to the subscribe
      span
    mukund-ananthu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    694cfde View commit details
    Browse the repository at this point in the history
  11. Add tests for nack and nack_with_response methods of Subscriber Message

    * Both these methods should add "nack start" events to the subscribe
      span
    mukund-ananthu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    27edc0f View commit details
    Browse the repository at this point in the history
  12. Add tests for modify_ack_deadline and modify_ack_deadline_with_response

    * Both these methods should add the "modack start" event to the
      subscribe span
    mukund-ananthu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c1f0ad8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e97b83c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8189b12 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    48ffe54 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d40b676 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    383ac2c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5ce0cf8 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Fix mypy errors

    mukund-ananthu committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5b21c93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b2020d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    26a86ec View commit details
    Browse the repository at this point in the history
  2. Fix mypy errors

    mukund-ananthu committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbe1e50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef0c391 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b71cf15 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da797cf View commit details
    Browse the repository at this point in the history
  6. Add subscription_id property to SubscribeOpenTelemetry

    * This field will then be used for span names of spans like Process Span
    mukund-ananthu committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a005057 View commit details
    Browse the repository at this point in the history
  7. Start process span

    mukund-ananthu committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    47c9d9a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8faa3cf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4189b22 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Configuration menu
    Copy the full SHA
    06ce105 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fa4773 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f30c2c4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ae2418 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Move adding dropped event and ending subscriber span from

    dispatcher.drop to leaser.maintain_leases
    
    * dispatcher.drop() is also called by ack, _retry_ack, nack and
      maintain_leases(when it wants to drop expired messages.
    * We only want to record the dropped event when the message is expired
      and hence dropped by the leaser
    mukund-ananthu committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    d1c870d View commit details
    Browse the repository at this point in the history
  2. Move ack called subscribe span event from message.ack() to

    dispatcher.ack() where the ack RPC is made
    mukund-ananthu committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    cb1f974 View commit details
    Browse the repository at this point in the history
  3. Move nack start event from message.nack and message.nack_with_response

    to dispatcher.modify_ack_deadline(deadline=0) when nack RPC is made
    mukund-ananthu committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7d6ea08 View commit details
    Browse the repository at this point in the history
  4. Move modack start event from message.modify_ack_deadline/with response

    to dispatcher.modify_ack_deadline()
    mukund-ananthu committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    e07fa4d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c384466 View commit details
    Browse the repository at this point in the history
  6. Add modack span

    mukund-ananthu committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    9ba47ff View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    2410a4e View commit details
    Browse the repository at this point in the history
  2. Add ack span

    mukund-ananthu committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b66fd19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54a88ba View commit details
    Browse the repository at this point in the history
  4. Add nack span

    mukund-ananthu committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    28a192a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c8c5eb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix modacks

    * Currently, subscribe_span is ended after modack end event is added to
      the subscribe_span. This should not happen, since subscribe_span
      should be ended only after ack,nack or drop, but not modack
    * Remove an extraneous modack start that was present in
      streaming_pull_manager.send_lease_modacks(). This is not required,
      since modack start and end events will anyways be added to the
      subscribe span in the dispatcher.modify_ack_deadline() method.
    * Replace the NamedTuple._replace() methods with creation of new
      NamedTuple ModackRequest items. This is because NamedTuple._replace()
      returns a new NamedTuple, rather than replacing the existing one. This
      results in the opentelemetry data not being plumbed down into the
      dispatcher.modify_ack_deadline_method.
    mukund-ananthu committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6ec7c35 View commit details
    Browse the repository at this point in the history
  2. Fix mypy errors

    mukund-ananthu committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7936911 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5874a96 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a791570 View commit details
    Browse the repository at this point in the history
  5. Add links to nack spans in the subscribe span in

    dispatcher.modify_ack_deadlin()
    mukund-ananthu committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3206c19 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    14250a1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    815f2a3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    94feeec View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5dd8fb8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b4fdd40 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ad13b59 View commit details
    Browse the repository at this point in the history
  12. Split the subscription name at one place

    * Addressing the review comment
    mukund-ananthu committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3977a6a View commit details
    Browse the repository at this point in the history