[dashboard builder] sticky tabs, container hierarchy, undo-redo fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-dash-builder-header
branch
3 times, most recently
from
c2d6b07
to
d4363b9
Compare
williaster
force-pushed
the
chris--fixed-tabs
branch
from
0f685b2
to
ef081ce
Compare
graceguo-supercat
force-pushed
the
gg-dash-builder-header
branch
from
d4363b9
to
2717baf
Compare
…, fix some isValidChild bugs
…on reaching undo limit
…ent and updates into layout for undo-redo, refactor save dashboard modal to use toasts instead of notify.
…r undo redo, save slice name changes on dashboard save
…ing, don't change grid size upon edit (perf)
…x double sticky tabs + side panel.
williaster
force-pushed
the
chris--fixed-tabs
branch
from
551e42c
to
5c55dfe
Compare
|
@graceguo-supercat I think this is ready to merge, I rebased on your latest and both sticky side pane + tabs works 👍 |
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 23, 2019
* First cut at app factory * Setting things back to master * Working with new FLASK_APP * Still need to refactor Celery * CLI mostly working * Working on unit tests * Moving cli stuff around a bit * Removing get in config * Defaulting test config * Adding flask-testing * flask-testing casing * resultsbackend property bug * Fixing up cli * Quick fix for KV api * Working on save slice * Fixed core_tests * Fixed utils_tests * Most tests working - still need to dig into remaining app_context issue in tests * All tests passing locally - need to update code comments * Fixing dashboard tests again * Blacking * Sorting imports * linting * removing envvar mangling * blacking * Fixing unit tests * isorting * licensing * fixing mysql tests * fixing cypress? * fixing .flaskenv * fixing test app_ctx * fixing cypress * moving manifest processor around * moving results backend manager around * Cleaning up __init__ a bit more * Addressing PR comments * Addressing PR comments * Blacking * Fixes for running celery worker * Tuning isort * Blacking
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 23, 2019
* Sweep #1 * moving a few more colors, fixing an import issue. * another include, another color nabbed. * more whittling. * moving filterbox css to less, standardizing colors in there. * nixing the css file I meant to nab in the last commit * Moving the variables file to a more global/sensible (I hope?) location. * FilterableTable moved from CSS to LESS, using color vars now. * more whittling * standardizing opacity stops * nails more colors, removes some old (seemingly unused) css * removing more dead css * DatasourceControl moved from CSS to LESS * BootstrapSliderWrapper CSS -> LESS * reactable-pagination CSS->LESS, color-conformed * FilterBadgeIcon CSS->LESS, conformed * deleting unused/deprecated css * welcome.css -> welcome.less (is this even being used?) * main.css -> main.less, standardized * there were two main.css files - this should have been in the last commit. * explore.css -> explore.less (not used anywhere?) * sql.css -> sql.less (also not used anywhere?) * another main.css -> main.less, standardized on colors * time to add shades and tints! * caught some colors in SVG that should be in LESS. * nixing commented css * deleting commented code * pulling in z-index vars lost in a conflict resolution
graceguo-supercat
pushed a commit
that referenced
this pull request
Oct 4, 2021
[SIP-4] add lerna monorepo and`@superset-ui/core` package with `SupersetClient`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to the new dashboard builder feature branch:
react-sticky)DashboardBuilderReact component tree to always include tabs regardless of whether top-level tabs exist. this makes adding/removing top-level tabs significantly more performant because we don't unmount/mount the entire dashboard which would otherwise happen because of the React diff-ing algorithm.react-bootstrapmountOnEnter=trueandunmountOnExit=false. note this allows us to lazy load visualizations in tabs because queries trigger on mountdashboardLayoutpart of the redux state tree, which is necessary to correctly affect and leverage undo/redo functionality._set_dash_metadatamethod, which will update slices in the slice table if their name changed"versioning"into the top-level ofdashboardLayoutinstead of within the layout objects themselves (@graceguo-supercat , this may break your local build becausegetInitialStatelooks for this version key in order to determine if it should convert the layout, you could add a line of JS to update it to v2 => save the dashboard, and then remove the JS)@graceguo-supercat