Skip to content

Commit

Permalink
made blank stuff properties
Browse files Browse the repository at this point in the history
  • Loading branch information
chenkasirer committed Dec 1, 2023
1 parent f5bef56 commit 88ab1e8
Showing 1 changed file with 12 additions and 16 deletions.
28 changes: 12 additions & 16 deletions src/compas_timber/parts/beam.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ def __init__(self, frame, length, width, height, **kwargs):
self.length = length
self.features = []
self._blank_extensions = {}
self.blank_frame = frame
self.blank_length = length

@property
def data(self):
Expand All @@ -109,12 +107,20 @@ def from_data(cls, data):

@property
def blank(self):
start, end = self._resolve_blank_extensions()
self.blank_frame = self.frame.copy()
self.blank_frame.point += -self.blank_frame.xaxis * start # "extension" to the start edge
self.blank_length = self.length + start + end
return _create_box(self.blank_frame, self.blank_length, self.width, self.height)

@property
def blank_length(self):
start, end = self._resolve_blank_extensions()
return self.length + start + end

@property
def blank_frame(self):
start, _ = self._resolve_blank_extensions()
frame = self.frame.copy()
frame.point += -frame.xaxis * start # "extension" to the start edge
return frame

@property
def faces(self):
return [
Expand Down Expand Up @@ -350,16 +356,6 @@ def extension_to_plane(self, pln):
elif side == "end":
tmax = max(x.keys())
de = (tmax - 1.0) * self.length

# if side == "start":
# tmin = min(x.keys())
# if tmin < 0.0:
# ds = tmin * self.length # should be negative
# elif side == "end":
# tmax = max(x.keys())
# if tmax > 1.0:
# de = (tmax - 1.0) * self.length

return -ds, de

def align_z(self, vector):
Expand Down

0 comments on commit 88ab1e8

Please sign in to comment.