Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compas main #121

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Compas main #121

merged 8 commits into from
Sep 1, 2023

Conversation

chenkasirer
Copy link
Contributor

Updated the Data interface in Beam and Assembly to comply with the changes in COMPAS core intended to be released in version 2.0.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes serialize that asssembly data!

Copy link
Contributor

@obucklin obucklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chen! I loked over the changes and mostly get what you are doing. You are right it is a good educaitonal opportunity.

Maybe let me know if or when I should update my COMPAS or CT to use the new serialization

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

this got me thinking we should probably already bump the version in COMPAS, so that other dependencies such as this one can declare it properly, because now it's somewhat inconsistent, this version only works with compas@main but it's nowhere visible

@@ -16,7 +16,7 @@ pydocstyle
pytest >=3.2
pytest-mock
sphinx_compas_theme >=0.13
sphinx >=3.4
sphinx ==7.1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still required? higher version of sphinx break the theme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 7.2.4 breaks the template, I opened compas-dev/sphinx_compas_theme#20.
Also Sphinx are seemingly dropping python versions like flies. 7.2.0 already doesn't support python 3.8 anymore..

@chenkasirer
Copy link
Contributor Author

Yes this all feels very sketchy and fragile. Anyways we can't add it to requirements.txt before there's an actual release of COMPAS 2.0. Is that what you meant?

@gonzalocasas
Copy link
Member

we can't add it to requirements.txt before there's an actual release of COMPAS 2.0. Is that what you meant?

yes, i don't know what's the best option for doing this, cut a 2.0-alpha release of COMPAS and use that?

@chenkasirer
Copy link
Contributor Author

we can't add it to requirements.txt before there's an actual release of COMPAS 2.0. Is that what you meant?

yes, i don't know what's the best option for doing this, cut a 2.0-alpha release of COMPAS and use that?

I'd be all in for that. I feel like we shouldn't be too far from 2.0 anyways. @tomvanmele what do you say?

@chenkasirer chenkasirer merged commit e88a035 into main Sep 1, 2023
12 checks passed
@chenkasirer chenkasirer deleted the compas_main branch September 1, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants