Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding plate to surface model #279

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Adding plate to surface model #279

merged 10 commits into from
Sep 13, 2024

Conversation

obucklin
Copy link
Contributor

@obucklin obucklin commented Sep 11, 2024

This PR adds plate elements to the SurfaceModel. This required a bit of refactoring, so there may be some bugs which pop up.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jonashaldemann
Copy link
Contributor

Nice feature!

Generally works, but I have some issues with this surface at the door:
image

If I bake the geometry, it looks fine:
image

Generally the question: Should the Baking Component be updated and how will we control the Texture Mapping there?

Copy link
Contributor

@jonashaldemann jonashaldemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baking is solved with another PR, maybe add the Grasshopper Preview Glitch to the To Do list and then merge it.

@obucklin obucklin merged commit f665c80 into main Sep 13, 2024
14 checks passed
@obucklin obucklin deleted the surface_model_plus_plate branch September 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants