-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leisure=garden & leisure=park have the same colour #3022
Comments
Example of what a "slightly darker shade" would look like: http://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=51.455193&lon=-2.589031 (different map style, but parks are the same colour, gardens different). |
Is my memory fading or is that the shade OSMCarto rendered gardens until recently? |
It's certainly the shade that OSM Carto rendered gardens in 2014 - I haven't changed it since then. |
This was changed quite recently,
8732cad
I agree Gardens and Parks should be different shades of green, where
we've been mapping "private" gardens around houses I think the lurid
green looks pretty bad against the buildings and also there is no
difference with parks, for example:
https://www.openstreetmap.org/search?query=edinburgh#map=16/55.9398/-3.1911
Cheers
Chris
…On 14/01/18 at 01:16pm, SomeoneElseOSM wrote:
It's certainly the shade that OSM Carto rendered gardens in 2014 - I
haven't changed it since then.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.
Reverse link: [3]unknown
References
Visible links
1. #3022 (comment)
2. https://github.com/notifications/unsubscribe-auth/AAOGFAmfkn8b57_Xcc5zD3ix4lxzed36ks5tKf4TgaJpZM4RdllQ
3. #3022 (comment)
|
What do you think about pattern for garden areas: grass green shade with small colorful dots (symbol of flowers) added to it? |
What's preventing it returning to it's previous shade, which from memory was the same as @SomeoneElseOSM's current. I'm not keen on patterned polygons. The translucence of footpaths makes it difficult to see within woods, even when zoomed in. |
Before, parks had the same color as grass, so areas of grass in parks were invisible. |
just wanted to mention that parks aren't always public, not even in OSM and
according to the wiki, and gardens are not always privately owned and might
be publicly accessible even if privately owned.
|
I have introduced this change in #2964. The problem with garden is that it can be a lot of things - it can be:
So it can be for leisure, decorative or food purposes (maybe some others too). With so much colors used already it's no longer the option to have separate color for every object type, some objects should be grouped. The garden has been clustered with grass areas, which I think is less similar than the park (grass only area vs different plants area). |
2018-01-15 17:08 GMT+01:00 kocio-pl <notifications@github.com>:
I have introduced this change in #2964
<#2964>.
The problem with garden is that it can be a lot of things - it can be:
- basically a public or private park, were you can walk (kind of
"Palace Garden" or "Botanical Garden"),
- small decorative area in the public place (similar to flower bed,
but filled with other plants)
- private green area at the backyard of the house, which is not just a
lawn (so called back garden <https://en.wikipedia.org/wiki/Back_garden>
),
- kind of food garden (thus similar to farmland).
So it can be for leisure, decorative or food purposes (maybe some others
too). With so much colors used already it's no longer the option to have
separate color for every object type, some objects should be grouped. The
garden has been clustered with grass areas, which I think is less similar
than the park (grass only area vs different plants area).
yes, there are different styles and kinds of gardens. Typically, I'd see a
garden as more intensively cared for (requiring more care), than a park
(yes, someone will now post a pic of his garden which he didn't care for in
the last 30 years, telling me he wants it exactly like this).
For the record: there are subtags for distinguishing different aspects and
types of gardens, and if this style would render some of them differently I
am sure, people would use them even more:
https://wiki.openstreetmap.org/wiki/Proposed_features/Garden_specification
|
FYI - I grabbed this screenshot when the changes to the garden colour rolled out. (The top is the new colour and the bottom half the old) My main issue is that I don't actually like the new colour and I do agree that we can't have a different colour for everything. However I do like to be able to see the difference, partly because there are so many Pokemon go players changing Gardens to Parks, and also because I think it's good to see a difference between the largely public park areas's and the largely private gardens. And I think gardens can be summarised as cultivated in some ways and parks which are overall large grass areas. |
@dieterdreist Thanks, I was not aware of it! |
Quick and dirty review:
I guess park and big walkable gardens are similar, small residential gardens might be rendered different (how? just like the lawn?) and food garden, if we can identify it, might be rendered different (like a farmland maybe?). |
Unless OSMCarto is using sub-tags to differentiate 'leisure=garden' I'm unsure how the multiple ways it's used in OSM is relevant. OSMCarto needs to ensure it doesn't clash with other entities it's gets added on top of. |
We are capable of using sub tags, so this is not a problem. Still we need to decide which ones are really useful and how should each type of garden be rendered. What are your propositions and remarks about There can be all the combinations - I have seen garden in the park, but also grass in the garden or park, I haven't seen garden in the grass area, but it's possible too... So I guess it won't help us to decide. |
2018-01-15 17:49 GMT+01:00 kocio-pl <notifications@github.com>:
Quick and dirty review:
- botanical- very close to a park, so should be rendered the same as
parks, so no change
no way, it is very different from a park (IMHO), it's a place of
conservation and study, no leaving of the paths, etc.
- residential - most of the time it will be probably "front yard/back
garden", I'm not sure how should they be rendered like, but they are not
for walking. But residence can be also a manor or palace and the garden can
be more similar to park then.
- community - I don't recognize this type at all just reading
definition.
- castle - definition not presented, probably something similar to
manor/palace, but narrow - probably it would be good to have a single tag
for all of them (or some hint should be added to wiki pages to simply tag
them as parks).
+1, I could maybe imagine having a type like "stately", which is
distinguished from "ordinary residential" gardens, but "castle" doesn't
seem helpful as a term here (and is ambiguous as well).
- monastery - most probably a food garden, but may have walking space
- I don't know.
IMHO ok to have this, although I would expect a monastery to have different
garden zones, from decorational to useful (vegetables and salad, herbs and
spices, orchard, etc.)
|
In the parks I know leaving the paths is not allowed (I know UK might be different, but that's how it is in Poland). In general they are walkable and this is the main similarity. Botanical gardens in Warsaw I know are meant for public just like a park, this is not contradicting scientific use. |
2018-01-15 18:17 GMT+01:00 kocio-pl <notifications@github.com>:
no way, it is very different from a park (IMHO), it's a place of
conservation and study, no leaving of the paths, etc.
In the parks I know leaving the paths is not allowed (I know UK might be
different, but that's how it is in Poland). In general they are walkable
and this is the main similarity. Botanical gardens in Warsaw I know are
meant for public just like a park, this is not contradicting scientific use.
yes, all botanical gardens I know are open to the public. The difference to
a park is that usually they impose more strict behavioural rules, often
require an entrance fee, typically have strict and not so long opening
hours., Cycling is usually not allowed, usually there are also indoor
areas, a lot of surface is intensively cared for (as opposed to parks where
most of the area is typically lawn) etc.
|
Sorry, I didn't see your previous post until I sent my last one. The example I gave in my OP isn't really described. From my experience:
Here's a Google 360 of another example of a garden with a park: |
For better understanding:
As usual i would suggest to look at:
|
2018-01-15 18:34 GMT+01:00 Christoph Hormann <notifications@github.com>:
For better understanding:
- leisure=park in OSM is an urban/near-urban area dedicated at a wide
range of leisure/recreation activities (unless it is abused by some native
English speakers for *anything named park*)
this really depends on the context, in some cases the park is dedicated to
a very narrow range of leisure activities (go for a walk, but not cycling,
not leaving the path).
|
In the parks I know cycling is also not allowed, some of them require fee and some are fenced. However making the list "gardens vs parks" is not our ultimate goal - of course we may find differences between types, but the real problem is how should gardens be rendered? There will be always differences between objects in a "cluster", but we need to find patterns of similarities. In other words: which clusters do you propose - and how should they be rendered?
This sounds like a clear difference, but I'm afraid it may be not very helpful. Gardening and leisure is where parks and gardens are similar in many cases (parks might not be about plants gardening, but I haven't seen it yet). And leisure is a common back garden purpose, just like food production, depending on the part of the world.
Some "national parks" are good example (look at the California). However that seems to be true for gardens too, that's why I think big residential gardens (like "Royal Garden") might be just tagged as parks. And this is the same common problem in Polish.
You're great at analysis, could you make such worldwide research? My research was not based only on my home town, but this is not what I do the best. |
2018-01-15 19:11 GMT+01:00 kocio-pl <notifications@github.com>:
@dieterdreist <https://github.com/dieterdreist>
In the parks I know cycling is also not allowed, some of them require fee
and some are fenced.
However making the list "gardens vs parks" is not our ultimate goal - of
course we may find differences between types, but the real problem is how
should gardens be rendered?
I agree it depends completely on the type of garden. I would expect
1. a botanical garden to be different from a park, but similar, e.g. like
zoos.
1b Also "rosarium" would be a similar "feature" garden, flower beds, etc.
2. allotments are probably the same as or similar to "community" gardens
(unsure on this, the communities are often quite different kind of people,
so maybe it makes to map less usefull not to distinguish), a set of smaller
gardens forming an unit and not surrounding a residence).
3. Stately gardens (or castle, royal, villa, etc.) as well as monastery
gardens and residential gardens could make a class of gardens serving a
residence (and could be seen as less interesting for the general public
from first to last, i.e. stately most intense colour, residential least).
|
Would giving gardens an outline solve this issue? |
It would make the small ones (like backyard gardens or flower-bed alike) look worse, so at least not in general. |
Interesting, we could use some patterns (rather monochrome, I guess) with light green too. Maybe that would be good for all the gardens that are not similar to parks (which maybe should be just tagged like a park). |
This idea seems to be general enough - we don't need to look at garden subtypes, which are not that clear it seems, so I like it even more. If we only add a note in the wiki to treat mainly "walkable" gardens as parks (not every park have to be garden with plants, but all the parks I know are in fact "walkable gardens"), no matter if the name includes Garden/Jardin/Ogród/... etc., that would be enough probably to render everything good. |
Well mapped botanical garden for testing how the new look will work with different types of sub-areas: |
2018-01-22 19:32 GMT+01:00 kocio-pl <notifications@github.com>:
Well mapped botanical garden for testing how the new look will work with
different types of sub-areas:
https://www.openstreetmap.org/way/26633037
another one in Berlin:
https://www.openstreetmap.org/way/125194752
another one with different tagging:
https://www.openstreetmap.org/way/26481293
|
The first one is interesting because it has an orchard inside. The second one should have probably operator defined instead of amenity=university. But what are really these parts? - like that: https://www.openstreetmap.org/way/226294581 Currently I think botanical gardens ( |
2018-01-22 19:49 GMT+01:00 kocio-pl <notifications@github.com>:
The second one should have probably operator defined instead of
amenity=university.
it is part of the university though
|
I tag the general campus this way, but not specific types of objects, for example garden of Warsaw University I tag as a garden (adding operator there would be good): https://www.openstreetmap.org/way/5081150 I think this is the case when both tagging has its merits, so we can choose what looks better - it's not bad data. I would argue that operator has a bit more sense. |
2018-01-22 21:11 GMT+01:00 kocio-pl <notifications@github.com>:
I tag the general campus this way, but not specific types of objects, for
example garden of Warsaw University I tag as a garden (adding operator
there would be good):
https://www.openstreetmap.org/way/5081150
in the case of Tübingen, the botanical garden is part of the "campus"
(actually, it is not a campus university I think)
https://www.uni-tuebingen.de/einrichtungen/zentrale-einrichtungen/botanischer-garten.html
|
I don't see any educational buildings there, so I wouldn't call it campus - just some garden which is university property (school can be owned by church, but I tag it as a school then). The same is true for BG of Warsaw University: However I added university tag for the rest of the area, where there are no more specific landuse than just general university: https://www.openstreetmap.org/way/25748407 But this is ambiguous question. The only important thing in this ticket is that in current state it probably won't work as a testbed for garden rendering. |
sent from a phone
On 22. Jan 2018, at 21:26, kocio-pl ***@***.***> wrote:
I don't see any educational buildings
if we continue, this should better go to the tagging ml ;-). Universities usually do research and education. AFAIK in the botanical garden both is done.
|
Another idea might be different shade of green, since we have a lot of them they work surprisingly well. One possible way might be to take green from camping site, which has different shade already, since we try to design outline for accommodation areas anyway (see #2290). |
After some time off, I think now that we should use just another kind of green for gardens. They can be very different in size, access and purpose, for example:
Flower pattern is appropriate just for some forms of the garden, dots (colorful or just black in rows) might be good for more types, but they suggest growing plants (which sounds to me like most important feature of gardens in general), which might be not proper for zen garden (very few plants) or small residential garden (mainly grass). So I guess we should use just another green shade, which is similar to grass, but maybe 10% lighter (or start with tourism=camp_site backbround, or maybe mix of grass and park colors), so we can show the structure if there are grass patches inside, but stay generic enough. We could also use dotted version as a generic pattern, so people will add more specific tags (type/style) which contain no dots - it's always better to have more specific tagging so generic values might have some annoyances/ambiguity. What do you think about it? |
I like this idea. because most of gardens contains plants, so we should be more focused on them than on the less popular types. |
I think black orchard pattern (with a different green shade in the background) would be good. |
I don't like the idea of adding new shade of green, bacause I think we have them too much now, and adding next one will made mess even worst. Look at this: I think we shoud look for ways to reduce amount of green shades, not add new ones. That's the reason why I proposed dotted pattern with current grass-green background. |
2 remarks:
|
IMHO the coloured patterns are drawing too much attention to themselves, even when the opacity is low. I believe patterns should be used sparingly, and always be as subtle as possible, because they always raise the noise level. The plant-nursery pattern example is still too dark for my taste. It should have even less contrast to the background. Maybe 40% opacity is enough to make it visible but not irritating? |
Could you provide such file? I have problems with processing opacity. |
I'm not sure, one has to check CartoCSS documentation or seek examples in our code. |
I like the previous '100%-version' more. |
I think 80% is visible good and not too noisy. Any other votes? |
Public gardens are often sections within parks but atm there's no visible difference:
https://www.openstreetmap.org/way/191318876#map=19/51.45508/-2.58866
Slight darker shade or a boundary?
The text was updated successfully, but these errors were encountered: