-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better shades for recreation_ground and other green areas #2964
Conversation
+1 I'd be happy with dropping leisure=common altogether though (due to it's overlap with different tags, UK-centered definition, and misuse of the tag both in and outside the UK). |
landcover.mss
Outdated
[zoom >= 10] { | ||
polygon-fill: @park; | ||
[way_pixels >= 4] { polygon-gamma: 0.75; } | ||
[way_pixels >= 64] { polygon-gamma: 0.3; } | ||
} | ||
} | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're introducing spurious whitespace
Do the labels need changing color too? |
i think it's better to make people aware of the problem on the Tagging list before doing this, since it has ~57k uses, but you're right, it's really not clear scheme. |
BTW - what about landuse=village_green (86k uses)? It is also rather local historical quirk and for example in Poland it was misused as a city green too because of a broken translation. Maybe we should make another ticket for them, what do you think?
Probably yes, i will check it later. |
Yes, landuse=village_green should be abandoned too (in coordination with tagging@). |
Just a history snapshot then: and a link to discussion: https://lists.openstreetmap.org/pipermail/tagging/2017-November/thread.html#34274 |
The issue with |
8ca55be
to
5a86155
Compare
I have removed leisure=common changes, as it needs a discussion on the list first. Label colors are the same in this group, so they don't need any change. |
I disagree with abandoning landuse=village_green. The first time I saw village_green it was described as an area set aside. I have not see the English legal description until now. I'd rather clear up the definition for areas outside of England. You see I have areas like this one. It was tagged as a park years ago but that implies that the city maintains the area as such. Nope that is not the use. It really is a buffer. But the retention basin use is .05 percent of the year. The real use is a green area that has been set aside so that a land developer is not creating ticky tack subdivisions of houses crowded upon houses. Also note that the land developer had to set aside a path to the larger park north of the second picture. landuse=village_green is perfect for this area as the area is more than just a retention basin. As the area stands now tagged with leisure=park, the area is just another Pokemon spawn point. |
2017-12-11 1:15 GMT+01:00 drkludge <notifications@github.com>:
You see I have areas like this one. It was tagged as a park years ago but
that implies that the city maintains the area as such.
From the picture I would also say park, and no, it doesn't imply the city
maintains the area.
Nope that is not the use. It really is a buffer. But the retention basin
use is .05 percent of the year.
being a park also a buffer/rentention basin isn't an issue either.
|
sorry jumping in on this late. I generally liked the difference in colours between gardens which tend to be private and parks which are generally public. So it was possible to identify public parks versus private gardens. Also I think that the old garden colour worked better with buildings, hence looked good when mapoping private gardens? |
garden and park says nothing about public or private. You would need access tagging for this. |
#3022 requested partial revert, people that commented here may wish to comment at this ticket |
Resolves #2956.
This should make the use of green backgrounds more consistent:
landuse=recreation_ground
andleisure=recreation_ground
should look the same and use leisure greenleisure=garden
should use park green[Update:]
leisure=common
changes are reverted (needs additional discussion)landuse=recreation_ground
Before
After
leisure=recreation_ground
Before
After
leisure=garden
Before
After