Change some amenities colour to grey

[Tomasz-W]

I propose to change colour of some non-cultural, non-service, free standing objects from amenity-brown to man-made-grey. Amenity-brown is heavy loaded right now and it includes tags from many different categories. As we already render towers, windmills or crosses in man-made-gray, and will render tourist information objects too, I think we should use this colour also for:

• amenity=bench
• leisure=picnic_table
• amenity=waste_basket
• amenity=waste_disposal
• amenity=recycling

[kocio-pl]

At the moment the difference is more or less whether the objects are usable (brown) or are mainly landmarks (gray), but that might make sense to "demote" some less important, but usable objects to gray to just offload brown.

[Adamant36]

We have a lot of cement bench's and picnic tables where I live that know one really uses and serve more like landmarks or markers for interesting places. So I sort of like this idea.

[Tomasz-W]

@kocio-pl I know it passed small amount of time since merging #3231 (it's not even rendered yet) but what do you think about changing also amenity=shelter colour to man-made-grey to match it with other non-cultural, non-service objects?

[kocio-pl]

It's possible to do it, but at the moment I'm not focused on this problem.

[Adamant36]

@Tomasz-W, as it currently stands both the general amenity=recycling and recycling_type=centre is rendered the same way and the code is connected. Recycling_type=container is not rendered at all though. I think that recycling_type=centre should remain as amenity brown and we should add rendering for it as an area. Then add rendering for recycling_type=container in grey. Which might spur mappers to use the recycling type tags more. Plus, also leave the general amenity=recycling as amenity brown but make it a separate feature in the code from the other two. What do you think?

[Adamant36]

Some test renders of everything except amenity=recycling and amenity=shelter

[kocio-pl]

I'm not sure that container in grey promotes adding recycling_type=* compared to lack of this tag in brown. About 70% already has it, so it's quite popular anyway.

Plus, also leave the general amenity=recycling as amenity brown but make it a separate feature in the code from the other two.

I don't understand what do you want to accomplish by that?

Current stats:

[Adamant36]

@kocio-pl good point. mostly the issue is that @Tomasz-W wanted to render amenity=recycling in gray, but I think recycling centers are amenities and should stay brown. Recycling containers could probably be colored gray, since they aren't amenities per say, but they aren't currently rendered. I think it would be worth showing them. Especially since we are already rendering normal waste baskets.

I thought doing that and rendering them in grey color would be a good middle ground to keeping amenity=recycling as brown. Then as a side thing, the numbers for recycling centers might increase if they are rendered as areas.

As it is the code for them currently looks like this
[feature = 'amenity_recycling'][recycling_type = 'centre'][zoom >= 17], [feature = 'amenity_recycling'][zoom >= 19] { marker-file: url('symbols/amenity/recycling.svg'); marker-fill: @amenity-brown; marker-placement: interior; marker-clip: false; [access != ''][access != 'permissive'][access != 'yes'] { marker-opacity: 0.33;

If recycling containers was added to the map in a different color then the other two, it would have to be codded separately. @Tomasz-W never said if he wanted amenity=recycling rendered in grey or if recycling centers were included. I was pointing out that they share the same code and it would have to be separated if they are rendered differently. Although, I guess it doesn't really matter. Hopefully that is a clearer explanation though at least.

to summarize
A. id like recycling containers to be rendered, in man made grey color.
B. id like recycling center areas to be rendered. Along with both them and amenity=recycling staying amenity brown color.

[kocio-pl]

GitHub hint - if you want to show a block of code, try using this notation:

https://github.com/gravitystorm/openstreetmap-carto/blob/90f769d57eff2ca55a297a7c4952e2206ca8e1f0/amenity-points.mss#L660-L669

which gives the output like this:

openstreetmap-carto/amenity-points.mss

Lines 660 to 669 in 90f769d

	[feature = 'amenity_recycling'][recycling_type = 'centre'][zoom >= 17],
	[feature = 'amenity_recycling'][zoom >= 19] {
	marker-file: url('symbols/amenity/recycling.svg');
	marker-fill: @amenity-brown;
	marker-placement: interior;
	marker-clip: false;
	[access != ''][access != 'permissive'][access != 'yes'] {
	marker-opacity: 0.33;
	}
	}

[Adamant36]

Thanks. I was wondering how to do that. It looks a lot better.

[Tomasz-W]

Yeah, containers/ centres may be distinguished from each other by man-made grey for the first one and amenity-brown for second one.

Generally I like the effect from test renderings. The difference is minimal, but it's all more logical in this way. @Adamant36 Please include also amenity=shelter.

[polarbearing]

Generally in favour of this move. For different types of recycling we would need to see a comparison, if the same icon is used for different meaning the difference should be sufficiently recognisable.

BTW, what is the big beast in the middle of this tile (man_made grey)?

[Adamant36]

Its either man_made=storage_tank, or Man_made=silo. It just got merged a few commits back. The icon is rather large, but they are large in person anyway.

[Adamant36]

@Tomasz-W, sorry about that. I was planning on including shelters and I spaced it until I was already working on something else. Here's some tests of it though.


I think the test renders for everything look good and it makes more intuitive sense for some reason. Would you be willing to come up with a new icon for recycling containers if need be? Like @kocio-pl says, just doing them in a different color might not be clear enough.

[Tomasz-W]

We have been trying with container designs some time ago, and it didn't go readable (see: #419 (comment)). I would stay just with colour change, as all amenity=recycling types are rendered the same way at the moment, it's a step forward eitherway.

[Adamant36]

Recycling containers in grey. I think it works.

[Tomasz-W]

Just for the note: at the moment recycling containers and recycling centres are rendered the same. There is PR needed to render containers in man-made-grey and centres in amenity-brown.

[matthijsmelissen]

@Adamant36 I think we should add memorials to the list too. What do you think?

[Adamant36]

Sounds like a good idea. I think they would qualify.

[Tomasz-W]

You mean change memorials colour to grey? They are brown because they have cultural/ historical meaning (see #3395), so I'm very against changing them to grey as trash bins etc. are.

[jeisenbe]

The only remaining item on the list is amenity=recycling, otherwise this issue can be closed.