Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amenity=shelter brown #3231

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

kocio-pl
Copy link
Collaborator

Observed in the German style.

Changes proposed in this pull request:

  • Make amenity=shelter brown, as it is not a transport nor accommodation utility, rather generic amenity

It looks more like other amenities on platforms and doesn't take away attention from real transport-related objects:

Before
8wn9n_af

After
tswelai8

It blends better with other amenities at the picnic site and with buildings:

Before
jojkzgyo

After
uazgkp m

It's also easier to spot in the forest:

Before
ze86_f8n

After
5 6r5fof

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black (like towers and hunting stands) and green would also options for me.

Brown rather suggests some more active staffed facility to me, given most of the other brown objects.

Anything is better than blue though.

@kocio-pl
Copy link
Collaborator Author

I would not use man made black, since they are useful for general public, unlike the objects you've mentioned, which are mostly landmarks. Green suggests some kind of leisure and has similar brightness as blue. Similarity to small trash cans on platform and picnic tables is what makes me think that brown is the best.

@kocio-pl kocio-pl merged commit 2e1a4d3 into gravitystorm:master May 14, 2018
@kocio-pl kocio-pl deleted the shelter-brown branch May 14, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants