Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move allotments to some kind of green #3411

Closed
kocio-pl opened this issue Sep 23, 2018 · 108 comments · Fixed by #3625
Closed

Move allotments to some kind of green #3411

kocio-pl opened this issue Sep 23, 2018 · 108 comments · Fixed by #3625

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 23, 2018

Currently allotments are dark orange with white dots. We have just changed farmland color to a shade of green, because it makes sense to have all the vegetation areas in green. Allotments are also closely related to vegetation, so I think some kind of green is needed.

Initial proposition using grass/garden background and using farmland background with dark dots like in garden - they are probably too close to them, so it's just a starting point:

Example area

Before

rcwsp9gs

Garden/grass background

l8y7mbd0

Farmland background with garden dots

r6xci7mc

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Sep 23, 2018
@dieterdreist
Copy link

dieterdreist commented Sep 23, 2018 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 23, 2018

Difference between farmland, garden or forest is prominent in my opinion, yet they all fit into vegetation and use shades of green. Using dark orange makes allotments closer to sand for example or built-up landuses (but more intense).

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 23, 2018 via email

@kocio-pl
Copy link
Collaborator Author

They are individual parcels of gardening for vegetables, fruits or flowers:

https://wiki.openstreetmap.org/wiki/Tag:landuse%3Dallotments#Description

@boothym
Copy link
Contributor

boothym commented Sep 23, 2018

Is there something else that you're planning on using this colour for? I don't see a big need for making a change - especially as your examples there are too close to other colours.

It would be great to have an image with all of the green colours together, showing grass, meadow, park etc. as I can't visualise what colours are currently used in osm-carto.

@kocio-pl
Copy link
Collaborator Author

I have no such plan, but in such a big and complicated project it's hard to live with arbitrary choices. It's always better to have some system and we're slowly doing such changes. For example I had no idea that changing playground color will make space for ice rink in the future (see #3330 (comment)), but it made sense to make it green (as other leisure objects) rather than blue (see #2249 (comment)).

@Tomasz-W
Copy link

Tomasz-W commented Sep 24, 2018

@kocio-pl I like farmland colour with garden dots. It would match planned amenity areas colour (#1991 (comment)), as allotments are partly an amenity areas and partly natural landcover areas. Do I see properly that there is no outline for allotment area? I think it should be used the same as amenity areas have it.

Yesterday I started playing with leisure=park colour, because I see it quite "crappy" in compare with the rest of osm-carto palette. I noticed that there is many of green shades used for areas which might be not covered by plants (at least not fully), so I think we should avoid adding more green to map.

  • landuse=cemetery
  • tourism=campsite/ caravansite
  • leisure=playground/ fitness_station/ dog_park
  • leisure=pitch
  • leisure=golf_course, miniature_golf

Notice also that in eg. Poland allotments often has no gardens, but just little houses with small grass areas around, so it's not obvious for me that they are always kind of garden, what gives the reason to avoid green shade here.

@boothym see: https://wiki.openstreetmap.org/wiki/AreasTab

PS. I just noticed that you called new colour of farmland "shade of green". It's not green, it's yellow! ;)

@polarbearing
Copy link
Contributor

How intensively the allotment is used for growing vegetable depends a lot.
In urban environments they are often used as a recreational environment for the family, where they have a patch of grass to play/sit on, some flower and veggie beds, and a hut to spend the weekend in.
With the tendency to organic food, there are now also other initiatives where regular farmland is sliced up, cultivated for vegetables only by individuals from the nearby city, but managed (e.g. irrigated, ploughed) by the farmer who rents them out.

@dieterdreist
Copy link

dieterdreist commented Sep 24, 2018 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 24, 2018 via email

@dieterdreist
Copy link

dieterdreist commented Sep 24, 2018 via email

@Slawek234
Copy link

Slawek234 commented Sep 24, 2018

"Allotments are also closely related to vegetation" but also it is a recreational area and often temporary or permanent (e.g. in the summer) residence. "Using dark orange makes allotments closer to" residential area. Current representation of this area in my opinion is very accurate.

Edit:

Also orange is closer to commercial or retail (which are reddish), but not to residential area (which is gray).

The color of the residental area by the years has changed. okay. Maybe now time to allmonts.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 24, 2018

I feel it's not this way. It's always about some kind of vegetation, but the residential role is restricted ("not for permanent residential purposes"). Also orange is closer to commercial or retail (which are reddish), but not to residential area (which is gray).

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 24, 2018 via email

@kocio-pl
Copy link
Collaborator Author

Because it can be similar to farmland and garden, I've made another proposition with 50% mix of both colors:

ihckulaf
screenshot_2018-09-25 openstreetmap carto kosmtik

@kocio-pl
Copy link
Collaborator Author

Less aggressive dots (0.5 opacity) and only 30% of grass to make it look a bit more different than garden:

mb_g0mcx
screenshot_2018-09-25 openstreetmap carto kosmtik 3

@Tomasz-W
Copy link

@kocio-pl Can you make version with 50% colour mix and 0.5 opacity dots?

@kocio-pl
Copy link
Collaborator Author

Sure:

laflyumk

screenshot_2018-09-25 openstreetmap carto kosmtik 4

@polarbearing
Copy link
Contributor

polarbearing commented Sep 26, 2018

How does that compare to other pattern-usage in this category? Orchard and garden comes to mind. We need to be able to distinguish them.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 26, 2018

Sure. Are there any places where allotments and orchards or gardens are close to each other? In the meantime we can look at https://wiki.openstreetmap.org/wiki/AreasTab examples:

30% garden/farmland mix
screenshot_2018-09-27 openstreetmap carto kosmtik 1

garden

plant nursery

orchard

vineyard

@kocio-pl
Copy link
Collaborator Author

30% mix with 0.5 opacity orchard dots:

screenshot_2018-09-27 openstreetmap carto kosmtik 2

rxm7dqb

@kocio-pl
Copy link
Collaborator Author

Close to each other (garden and 30% allotments)

s1_xbeeo

@polarbearing
Copy link
Contributor

Thanks for pointing me to that page, and to @geozeisig for maintaining it.
The allotments need to be recognised in particular when none of the others are nearby, and for this purpose I feel all proposals above are too similar to them.
IIRC a while ago we changed allotments from diagonal hatching to the white dots. I would like to preserve some specific element, as they are not just one particular agricultural crop, they have that recreational value.
Ideas:

  • white dots (as current) on one of the green tones (might be too weak?)
  • some other pattern? diagonal hatching again, or a white square grid, or a pattern of square outline symbols?

@kocio-pl
Copy link
Collaborator Author

I think dots opacity is not needed - 30% mix with orchard dots (this is the same pattern as currently, but black instead of white - footpaths are better visible):

sxpelxmq

@kocio-pl
Copy link
Collaborator Author

There are more patterns available in new version of @imagico pattern generator, like rings for example:

http://www.imagico.de/map/jsdotpattern.php

http://blog.imagico.de/more-on-pattern-use-in-maps/

@Tomasz-W
Copy link

Tomasz-W commented Sep 27, 2018

@kocio-pl Please upload some test renderings comparing 50% mix with 30% mix (both with orchard pattern) on mid-zoom levels. I would like to see espessialy how would it look in 2 cases: surounded by farmlands and surrounded by some green areas. I think it's important to rate possible colours in these situations.

@polarbearing
Copy link
Contributor

White rings on E4EFCA (imagico ring 6 thick dist 15)

white_rings_on_e4efca

White squares 8 on E4EFCA (dist 15)

white_square_8_on_e4efca

White square rings 8 on E4EFCA (dist 15)

white_square_rings_8_on_e4efca

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 3, 2018

OK, I've made a PR with version 10:
#3548

@DaveF63
Copy link

DaveF63 commented Dec 29, 2018

Struggling to see the purpose of this amendment. The outcome is a bit too much like garden. 'Before' is best option.

@polarbearing
Copy link
Contributor

Dave, I am struggling to find your constructive contributions during the 3 months of discussing this matter. Please note however that the finally chosen pattern is in the PR #3548, not here in the top post.

Certain similarity to garden is intentional, since the contributors here indeed consider both features similar. The white-square pattern makes the rendering however distinct enough to distinguish them.

@imagico
Copy link
Collaborator

imagico commented Dec 29, 2018

@polarbearing - dismissing critique because it was not brought up at the right time according to some opinion is not a good idea. @DaveF63 stating his view here now is completely fine.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 5, 2019 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 5, 2019

Sure, I'm interested in seeing test rendering, it might help to distinguish them earlier. Thanks for checking it!

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 6, 2019

I'd like to see especially:

  • how does it look when it's close to the cemetery?
  • how would it look with our pattern?

@kocio-pl kocio-pl reopened this Jan 6, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 6, 2019

It works well!

The color that @imagico used for allotments is #c9e1bf, which is closes to our current scrub color, but with Δ of 7 it's ok. On his branch the scrub color is a little more saturated, which increases the difference to over 10, just as distinctive as the differences between other green colors currently. #c9e1bf is fairly far from cemetery/graveyard color (aacbaf), which is much darker. The next closest color after scrub is golf (#b5e3b5) but this is Δ 10, which is enough. Then forest and grass are about Δ 12.

Harburg, near Hamburg, Germany - cemeteries, parks, leisure, forest are visible
(There are small patches of scrub in the industrial port area on the left, and by the motorway on the right)
https://www.openstreetmap.org/#map=13/53.4628/9.9847
z13 Current #cdebb0 - same as garden / grass
z13-harburg-master

z13 New color #c9e1bf with pattern
harburg-allotments-c9e1bf

Example at z13 without the pattern, useful to consider if we stop fading colors at z12:
#c9e1bf no pattern
z13-harburg-no-pattern

Rural area near farmland, farmyards, orchard, scrub, meadow etc.
https://www.openstreetmap.org/#map=14/53.4933/10.0788
z14 #c9e1bf with pattern
z14-tatenberg-allotments-c9e1bf

(I previously tried to find a color similar to this when we were testing, but I failed to find one that would not be too close to golf, scrub, parks or orchard. This one looks just right. Thanks, @imagico)

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 6, 2019

Pattern makes it more noticeable. Could you also try adding the outline?

@Tomasz-W
Copy link

Tomasz-W commented Jan 6, 2019

What about lighter (half-transparent) pattern?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 6, 2019

Second option. This is with the previous dot pattern with this color:

z13 Harburg #c9e1bf with former dots pattern
z13-harburg-new-dots

z14 Tatenburg #c9e1bf with dots
z14-tatenberg-new-dots

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 6, 2019

What about lighter (half-transparent) pattern?

Good idea, I agree that the pattern color needs adjusting. I just used the current pattern file for the most recent pictures. Here's a subtler version, with 50% opacity.

Third option with less prominent pattern (50% opacity) for testing only - would need a new pattern file)
z13 harburg
z13-harburg-50percent
z14 tatenberg
z14-tatenberg-50percent

Fourth option (75% opacity for testing) - intermediate
z13
z13-harburg-75percent
z14
z14-tatenberg-75percent

Could you also try adding the outline?

Farmland and farmyard have outlines starting at z16, so that's the zoom level I've used here, and I've tried to darken the fill color by a similar amount. It does help show the border between two adjacent named allotments:

https://www.openstreetmap.org/#map=17/53.47358/9.94350
z17 Master - Harburg allotments
z17-allotments-master

With outline (and 75% opacity of pattern)
z17-allotments-75

With outline (50% opacity pattern)
z17-allotmentes-50

https://www.openstreetmap.org/#map=16/53.4910/10.0811
z16 Master - Tatenberg allotments
z16-tatenberg-master

With outline (and 75% opacity pattern)
z16-tatenberg-outlines-75

With outline (50% opacity pattern)
z16-tatenberg-50

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 7, 2019

Here's some test with the addition of plot outlines and ref numbers for plots.
I've had some trouble finding allotments=plot with ref=* - there are plenty in Germany, but not in the cities that I've downloaded, and this is the only location in all of Wales with ref:

Cardigan, Wales https://www.openstreetmap.org/#map=18/52.08803/-4.64677

z18 - Ref numbers, plot and landuse outlines, 75% opacity pattern with #c9e1bf
z18-allotments-75percent-new-border-ref
z19
z19-allotments-75percent-new-border-ref

With numbers only (and current colors, no borders) - for comparison
z18
z18-cardigan-allotments-numbers
z19
z19-cardigan-allotments-ref

@Tomasz-W
Copy link

Tomasz-W commented Jan 7, 2019

75% pattern + new colour is nice, but proposed outline is too strong.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 7, 2019

Here's slightly thinner and lighter borders (I've changed the landuse=allotments border from 0.7 to 0.5 and the plot border from 0.5 to 0.3, while both are 15% darken than the fill instead of 20% darker)
z18 squares at 75% opacity
z18-cardigan-allotments-thinner-lines
z19
z19-cardigan-allotments-thinner-lines

With dot pattern:
Here's slightly thinner and lighter borders (I've changed the landuse=allotments border from 0.7 to 0.5 and the plot border from 0.5 to 0.3, while both are 15% darken than the fill instead of 20% darker)

z18 squares at 75% opacity
z18-cardigan-allotments-thinner-lines
z19
z19-cardigan-allotments-thinner-lines

With dot pattern:
z18 dots
z18-dots-lines
z19 dots
z19-cardigan-dots-lines

Cardigan, Wales https://www.openstreetmap.org/#map=18/52.08803/-4.64677

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 7, 2019

In general I like the proposition very much. The color is substantially different, so it should not look a like a grass even on medium zoom levels (this was the weakness of our solution), which would be good enough when we started. But now I like squares pattern more, since it is more meaningful than just dots and even easier to recognize.

So squares at 75% opacity with thinner and lighter borders are great for me. Feel free to tune it more if you feel it could be even better.

@Tomasz-W
Copy link

Tomasz-W commented Jan 7, 2019

@jeisenbe Can you test '75%' version with outline values from e.g. landuse=farmland? I think it's still too strong.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 8, 2019

Can you test '75%' version with outline values from e.g. landuse=farmland? I think it's still too strong.

The outline above is supposed to be similar relative darkness as farmland outline, and the width is 0.5 on both.

Here's a slightly lighter color for the outline: the new allotments fill, darkened 10%. I think it is too faint to be seen between two different areas of allotments, especially when the lines are vertical or horizontal like in this first picture

Bremen, Germany: https://www.openstreetmap.org/#map=16/53.1070/8.8134
Dots with 20% darker outline so you can see it:
z16-indenhufen-darken20-dots

Compared to squares with 10% darkened outline:
z16-indenhufen-allotments-10darker

It's ok when the allotments are up against blank areas, but there's really no need for an outline in this case:
z18-cardigan-10darker

Offsetting the outline into the polygon would help some: (offset -0.5 pixels, darkened 10%)
z16-indehufen-lineoffset05-darken10

But 15% darkened is better visible:
z16-indehufen-lineoffset05-darken15

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 8, 2019

Looking around Bremen and Hamburg, I've realized that we should have tested areas of allotments with buildings. We previously tested areas with paths and tracks only, but most allotments in German-speaking countries have small shacks, or cabins, or even small houses. This looks bad at z14 and z15 with the current strong squares pattern:

Bremen, Germany: https://www.openstreetmap.org/#map=16/53.1070/8.8134

Small squares (2px on 4px grid), as in current pattern, 0.75 opacity:
z17 (with 15% darkened border, -0.5 line-offset)
z17-ahnewehrweg-squares

z16
z16-indehufen-lineoffset05-darken15

z15
z15-hohweg-squares

z14
z14-walle-squares

Dots pattern (previous allotments pattern)
z17
z17ahnewhrweg-dots

z16
z16-indenhufen-darken15-dots

z15
z15-hohweg-dots

z14
z14-walle-dots

2px squares on 8px grid

  • This still uses the small squares, but spaces them twice as far apart, like the previous dots
    z17
    z17ahnewhrweg-2px-8x-squares

z16
z16-indenhufen-2px-8x-squares

z15
z15-hohweg-2px-8x-squares

  • I believe this would also work, but the dots are a little less obtrusive

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 8, 2019

With so busy places current solution looks much better than a proposed one, especially on midzoom, no matter what pattern. I believe they are just well mapped, because in Poland it's the same in reality, buildings are just not drawn in many cases.

I'm not sure what to do with that problem.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 8, 2019 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 8, 2019

What we have now looks better for me than new proposed color when there are so many buildings.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 8, 2019 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 8, 2019

I would miss this nice pattern, but everything is acceptable for me here.

@Tomasz-W
Copy link

Tomasz-W commented Jan 8, 2019

I prefer squares pattern over dots one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.