Render leisure=ice_rink

[jragusa]

Fixes #796

Changes proposed in this pull request:
Render leisure=ice_rink with glacier background and pitch colour text

Test rendering with links to the example places:
https://www.openstreetmap.org/way/87188308

Before

After

[kocio-pl]

It looks to me that we should also add the outline. Code for glaciers is here:

openstreetmap-carto/shapefiles.mss

Lines 39 to 53 in d8fc3c7

	#icesheet-outlines {
	[zoom >= 8] {
	[ice_edge = 'ice_ocean'],
	[ice_edge = 'ice_land'] {
	line-width: 0.375;
	line-color: @glacier-line;
	[zoom >= 8] {
	line-width: 0.5;
	}
	[zoom >= 10] {
	line-dasharray: 4,2;
	line-width: 0.75;
	}
	}
	}

[kocio-pl]

And maybe the outline color could be different to make it more distinguishable from glaciers. I believe green could be good (the same as in label).

[jragusa]

It looks better, what do you think ?

[kocio-pl]

Nice, it is clearly different enough from glacier:

[kocio-pl]

I think we still need [way_pixels > 3000][is_building = 'no']condition here - we don't like to have just the outline without the fill.

[jragusa]

Something like: [zoom >= 10][way_pixels > 3000][is_building = 'no'] { ?

[kocio-pl]

Yes, most probably. :)

[jragusa]

ok done :)

[kocio-pl]

Did you test the code after the change? I suggest to always do it, no matter how small and innocent the change looks like. 😄

In this case I get error (shortened):

Postgis Plugin: ERROR:  column "is_building" does not exist
.
.
.
  ) AS landcover

Which means that landcover data layer is not aware of is_building ("virtual" column), because this hasn't been defined there. See for example:

openstreetmap-carto/project.mml

Line 2020 in e58cc3c

CASE WHEN building = 'no' OR building IS NULL THEN 'no' ELSE 'yes' END AS is_building -- always no with the where conditions

and try to put it after this line inside landcover layer:

openstreetmap-carto/project.mml

Line 139 in e58cc3c

CASE WHEN religion IN ('christian', 'jewish', 'muslim') THEN religion ELSE 'INT-generic'::text END AS religion,

This might be not enough, but that's probably something to start digging. If you will have any problems with that, just tell here.

[HolgerJeromin]

We should probably do something with
seasonal=winter/yes (or better !=no)

[kocio-pl]

Thanks. What do you propose? Would simply reusing water type of rendering work for you?

[jragusa]

I removed the is_building condition and buildings are not affected by the PR:
https://www.openstreetmap.org/way/246399017

Edit: actually, the pitch is covered by the building. We can see a very slight green outline

[kocio-pl]

I believe this is not a good solution and proper solution (selecting only non-buildings for area+outline and maybe labels for all the cases) should be used instead.

[kocio-pl]

@jragusa Are you willing to deploy proposed solutions in this PR?

[jragusa]

Sorry @kocio-pl for the delay, I was busy last week with manuscript corrections.

I tested your proposition and I get an error. I'm testing the suggestion of HolgerJeromin. Generally, this problem of building condition is not restricted to ice_rink and also concerns sports_centre for example. Actually, the outline width is 0.3 for the latter with respect to 0.5 for ice_rink which explains why there is no graphical glitch for sports_centre.

[kocio-pl]

OK, no need to hurry - I prefer people learning how to make a proper code in this style, so we could resolve more complex problems than just adding icons for shops. Do you need some help with this?

[kocio-pl]

Hi, how are you with this code? Do you need some assistance or you want to go on with it yourself?

[jragusa]

@kocio-pl I still have problem with the condition is_building. It's used for text but when I tried to define it for surface, I got an error from projet.mml. I will investigate this on Thursday.

[kocio-pl]

Do you have any news about this problem?

[jragusa]

@kocio-pl this PR is ready to merge

[jeisenbe]

I fetched this branch, and I also was notified of a syntax error. Adding the comma fixed the problem, as suspected.

…

On Sun, Dec 16, 2018 at 12:16 AM kocio-pl ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In project.mml <#3330 (comment)> : > @@ -139,6 +139,7 @@ Layer: ('railway_' || (CASE WHEN railway = 'station' THEN railway ELSE NULL END)) AS railway, CASE WHEN religion IN ('christian', 'jewish', 'muslim') THEN religion ELSE 'INT-generic'::text END AS religion, way_area/NULLIF(!pixel_width!::real*!pixel_height!::real,0) AS way_pixels, + CASE WHEN building = 'no' OR building IS NULL THEN 'no' ELSE 'yes' END AS is_building -- always no with the where conditions @matkoniecz <https://github.com/matkoniecz> @sommerluk <https://github.com/sommerluk> Maybe you could check it too? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3330 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshIECmxzkGOwJzrTGLif7KZ4h2DcAks5u5RJPgaJpZM4VvUAF> .

[kocio-pl]

Thanks, it works! And now we have a 4 year old issue fixed... 😄