Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render the name of big military areas earlier #861

Closed
dieterdreist opened this issue Aug 7, 2014 · 3 comments · Fixed by #941
Closed

render the name of big military areas earlier #861

dieterdreist opened this issue Aug 7, 2014 · 3 comments · Fixed by #941
Labels
landcover
Milestone
Bugs and improvem...

Comments

@dieterdreist
Copy link

E.g. here: http://www.openstreetmap.org/way/22911818
the name should be there in zoom 10 or 11, but when it actually get rendered in a tiny font in zoom 15 you don't even see the extent any more and it is hard to associate this tiny label to the huge polygon that spans more than the screen (1980x1200) at this zoom level.
@matthijsmelissen
Copy link
Collaborator

We should probably go for a solution similar to lake name rendering, where we let the minzoom depend on area_size.

See also #686.

@dieterdreist
Copy link
Author

2014-08-07 18:35 GMT+02:00 math1985 notifications@github.com:

We should probably go for a solution similar to lake name rendering, where
we let the minzoom depend on area_size.

See also #686
#686.

+1, maybe can be extended to all kind of areas that we render? When they're
big enough they could display earlier. There's a performance price to pay
of course.

@matthijsmelissen
Copy link
Collaborator

How concerned are we with performance on mid zoom levels, say z10-z14? There are relatively little tiles on these zoom levels, so the time an average server spends on these zoom levels is probably negligible compared to total rendering time anyway.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 12, 2014
@matthijsmelissen
Major rewrite landcover labelling
a471e72 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
@matthijsmelissen matthijsmelissen mentioned this issue Sep 12, 2014
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 21, 2014
@matthijsmelissen
Major rewrite landcover labelling
15e5c0e 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 22, 2014
@matthijsmelissen
Major rewrite landcover labelling
c0e1a2e 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
landcover
Projects
None yet
Milestone
Bugs and improvements
Development

Successfully merging a pull request may close this issue.

Major rewrite landcover labelling matthijsmelissen/openstreetmap-carto
2 participants
@dieterdreist @matthijsmelissen