Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amenity=bicycle_repair_station icon #1864

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

This adds the icon for amenity=bicycle_repair_station icon at "small amenities" zoom level (z>=18) with low priority in amenity-brown color. TagInfo shows 1k+ uses and this makes bicycle facilities more complete.

The icon itself is made of elements taken from bicycle parking and car service, of course:
bicycle-repair-19

@pnorman
Copy link
Collaborator

pnorman commented Sep 22, 2015

Working version of #1353, which was rejected.

I'm still skeptical, for the same reasons as before.

The usage has increased, but is still low, and about half the usage is from an import.

@dieterdreist
Copy link

I'm in favor, the icon is easily recognizable and doesn't introduce different symbols because it consists of patterns we already use

@kocio-pl
Copy link
Collaborator Author

I had no idea it was already proposed, but it was so simple to create that I just forgot to check...

I think this is similar case as with motorcycle parking, so let me just link to my previous comments: #1650 (comment), #1650 (comment). In a nutshell: I tend to think about the "cluster" of things, so if we're able, we should render every common item related to given type of transport. I still don't have a tyres shop icon designed for example, but it would make car "cluster" more complete.

The interesting note is however that about imports. How should I check how many mappers have used it and what is the imports rate? I don't try to rely on the numbers, but for now I can only check the number of uses and 1k + wiki page assures me it is solid. Motorcycle repair has only 0,2k, so for now I just haven't looked at it, but it also is similar and has a wiki page.

@matthijsmelissen
Copy link
Collaborator

Do you also want to render the name tag of this object? Currently the queries for the name fields are updated, but in the .mss file it doesn't display a name now...

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Nov 3, 2015

If I understand correctly, this is intentional hack. For example telephone also doesn't have its label rendered, yet it's included in the same section.

@matthijsmelissen
Copy link
Collaborator

I think this is a tag with a rather specific audience and still relatively low usage. I'm therefore going to reject this PR. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants