Add rendering for amenity=bicycle_repair_station #3069
Comments
|
It's a duplicate of #1353, let's discuss it there. |
|
Sorry, it seems that we had 2 PRs which were rejected then (#1353 and #1864), but no issue ticket before. We already have the icon, so making a PR would be rather easy now: |
|
Notice that @nebulon42 icon include single-sided wrench, and it could be confused with the key from amenity=bicycle_rental. I don't know is the brown color (from PR test renderings) right for this feature. Bicycle parkings and rentals are blue. |
|
Rental has the thicker side on the left while repair has the thicker side on the right. This should work against confusion. |
|
Anyway, I would like to see a test rendering with my icon, so I'm putting Gist link: |
|
Voila. Still quite similar on the first glance. I wonder if we might turn the repair icon 90 deg, so the bike comes in repair position, and the spanner easier to distinguish from the key. Or the bike upside down. |
|
For comparsion:
|
|
The 90 deg in the middle works for me. Maybe with the wheels towards the spanner. |
|
Yes, the second one is good. But I would switch bike and tool (so you can read the symbol from left to right). Then it will also have the wheels towards the tool, which I agree should be better. |
Good point. Version with bike on the left side: Gist link (with two versions of the icon): https://gist.github.com/Tomasz-W/9c66f9b37345fdb35f8f6cecce9fe925 |
|
Wheels towards the spanner: |
|
Version with wheels to the edge reminds me wall hangs, so I like it more. We should choose between this: |
|
It helps to use numbers as a reference if there are few propositions and they are changing into new versions. |
|
I would go for number 2 (with bike in the left side) |
|
On GitHub hash+number links to some old issues. 😃 |
|
We already show car repair, for me it's better if they are similar and they are distinct enough for me (see #3069 (comment)), so I still prefer Osmic version. I also think that brown is better (which also will make it visually different than rental) - blue is for direct transportation (like gas station), repairing is brown and car/bicycle shop is violet, because buying/repair is indirectly related to journey. |
|
I just don't like this single-sided wrench. If you want, I can make a car repair icon with double-sided wrench, and both icons will match each other. |
|
Not sure about the colours. We need to distinguish a repair shop (where you have your bike repaired and pay money) from the repair-station (self service, more on-the-go). Thus I would see the repair-station in blue (as in the render test above), it is already distinguished from rental by the hanging bike. To summarize:
|
|
I would prefer to show services (including repairs) in brown, selling things in violet and blue only when this is something you do to get the vehicle or (rental) let it rest (parking). |
|
The only |
|
Through past weeks I've been working in a bicycle service :) This time gave me few thoughts about this issue. First 4 icons are the current ones, and last 2 ones are my propositions.
Gist link: https://gist.github.com/Tomasz-W/4607d7fcbb642d9538e04bd784fb5f01
Gist link: https://gist.github.com/Tomasz-W/30bae143f810026cfad5d9cfe813319e |
|
Yes it's a service, like hair dresser and nail studio, which we do purple: Brwon has amenities like bar, restaurant, museum, which do not compare to car/bike-repair. |
|
Would blue really be that crazy? (For both bike and car repair.) They're transport related, and (based on the above comments) they don't seem to cleanly fit into either the amenity or shop categories. We render fuel stations in blue and I could make a pretty good argument that they should be violet. |
|
I would agree with @Tomasz-W about shop=car_repair being more like an amenity. A lot of times car repair places are often a part of a larger business that provides other services which can be car related or not. Like all the car shops in Walmart, Les Schwab Tires, or gas stations with both a convince store and a place to get your car checked up on. Also, places that do things like oil changes and check tire pressure exclusively are more like an amenity then anything. |
|
sent from a phone
On 2. Aug 2018, at 18:07, meased ***@***.***> wrote:
Would blue really be that crazy? (For both bike and car repair.) They're transport related, and (based on the above comments) they don't seem to cleanly fit into either the amenity or shop categories.
I agree with blue for bicycle repair stations
|
|
I feel we need different colors to differentiate things from the same category a bit. I would use blue only for things directly related to journey, like gas/electric station, parking or bus stop. Repair station is not directly related, just like embassy for example, so brown looks better. |
|
@Adamant36 After discussion summary, I think you should use amenity-brown 'wrench above' versions in both cases. |
|
@kocio-pl As we are adding more and more brown icons to the map, your idea of chnging gastronomy objects to orange seems reasonable. Can you open an issue with it, just to have it on mind and test it someday? |
|
I don't get the system. You argue for the repair services to use the same colour than tourism-brown, but propose to move tourism-related gastronomy to a different colour? Maybe we should have a meta-ticket first to clarify the colour schemes and what concept they relate to, before shuffling individual cases around. |
Going to a restaurant or some fast food in your own city makes you a tourist then? Interesting... |
|
The problem of classification is that many objects can belong to multiple categories. It might be a problem, but it also gives us some space to tune the things a bit. Maybe we could discuss the system, but we have too few colors available to make it strict and rich, color reuse is already necessary (see the problem with offices - #3163 (comment)). I'm currently not interested too much in object colors (including gastronomy), so if anyone is interested, please open the issue and - more important - lead the discussion about it. |
|
@Tomasz-W OK. I'll probably do this next after outdoor seating gets merged. I also think it would be a good idea to open a meta ticket in order to discuss @polarbearing's concerns and the system in general though. Then we can change the color again later if need be. I don't know what to think about it at this point myself though, because like Kocio-pl says, lots of objects can belong to multiple categories. Plus, it seems like there's other priorities. So I rather get the icons on the map now in brown at least and deal with the color thing as a separate issue. |
|
I’ve always opposed the idea to associate museums or artwork with tourism, but that’s how we tag them (me included), it is just a word (that doesn’t hit it nicely), seeing food related amenities as tourism related neither is helpful from my point of view (although for some it is the case). Therefore I would not insist in brown for tourism related stuff.
Bicycle repair stations to me are a feature similar to the compressed air facilities you find at petrol stations, a place you can go to do basic fixes “on the go”/ while you are not at home.
|
|
What do you think on this one @Tomasz-W? Wrench above and amenity brown for both? It seemed like it was mixed on what to go with, but the discussion appears to have stalled out. So id like to do the PR and get it rendered already if its possible. |
|
Surely wrench above in both icons, but as we have around 50:50 for amenity-brown/ transportation-blue, please make test renderings with both colours to compare. It would be good to see how these both colours matches bicycle/ car parkings/rentals placed nearby. |
|
@Adamant36 Are you willing to write code for this feature in a week (before #3370)? I'm asking because near my church where I'm every Sunday there is one bicycle repairing station, and every week when I see it, it reminds me OSM and lack of this icon. If it won't show on map till october (when most of people in Poland hide their bikes to the basement), I will consider it as my fail as unofficial icon-issues manager here ;) ;) If you have some other plans or you just don't have time for it, I will fully understand, so don't worry. |
|
@Tomasz-W, sorry about that. I really wanted to get it through before now myself. I was waiting for the conversation to figure itself out and it took longer then I expected. Plus, I got distracted with other stuff. I did some looking around with car repair and seems that it has some weird code and is render as a purple icon with brown text for some reason. So id like to just leave it as is except for updating the icon, and deal with it in another PR. That way we can get this done before #3370 at least. Here's some test renderings of bicycle repair stations in the mean time though, with both brown and blue. I don't know if they are the best spots, but I can find more if necessary. I'll do a PR for it as soon as its figured out and maybe @kocio-pl can fast track it if need be. Since there's already been a lot of discussion here. Otherwise, I'll feel a little like I failed on it too. I think brown makes the most sense. Especially in the pictures with the car wash next to the gas station. Where it is more associated with the car wash by being brown then the gas station or hotel. Which makes sense. Plus, it makes it slightly easier to see in the first picture next to the blue bike path by being brown. |
|
I think this feature in blue looks like more important than it actually is. As this is free-standing non-interactive small amenity, it should be in amenity-brown. As #2658 may be hard to resolve but on the other hand it would be nice to have bicycle repair stations on map, you are right to do at least icon update and left colour inconsistency fixing for later (btw. there is the same problem with shop=massage, it's propably because we don't have amenity-brown generic dot and also no leisure-green generic dot) |
|
@Tomasz-W, I agree. I'll wait awhile to see if anyone else chimes in and then do the PR with amenity brown later tonight if there is no major objections. |
|
Given that this icon is one of the more detailed fiddly ones, it is more readable in a darker colour, so brown wins this time. |
|
Ok, brown is it for me
Martin
Am 14. Sep. 2018, 00:31 +0200 schrieb lakedistrictOSM <notifications@github.com>:
… Given that this icon is one of the more detailed fiddly ones, it is more readable in a darker colour, so brown wins this time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sorry but I cannot consider this as a criterion for selecting an icon colour. There has to be a logic for the map reader. If the icon is not recognisable, it would need to be tuned, not moved to another colour. That said, I could agree on brown; as long as it - being a self-service amenity - is not the same colour as the serviced car-repair. See related discussion in #3126 (crafts). |
|
@polarbearing The colour choice was already between blue and brown based on logical reasoning, and I was just saying that it stood out better in brown. Of course blue might be better in other areas, but my comment was based on the example rendering above. |
@Tomasz-W You can consider it your victory then. 😄 Of course meeting this goal (or any other single goal) is just kind of coincidence, but it's hard to measure coordinating work, so this symbolic win and the fact that things go smooth is quite good benchmark. I consider you not only good icon designer, but also talented project manager. Thanks! ❤️ |
|
Hello
You are my hero and made my Sunday, the icon did just now appear for my
hometown. Thx for the great work
I did not yet hide my bicycle
Martin
Am 21. Sep. 2018, 03:22 +0200 schrieb kocio-pl <notifications@github.com>:
…
If it won't show on map till october (when most of people in
Poland hide their bikes to the basement), I will consider it as my
fail as unofficial icon-issues manager here ;) ;)
@Tomasz-W <https://github.com/Tomasz-W> You can consider it your
victory then. 😄
Of course meeting this goal (or any other single goal) is just kind of
coincidence, but it's hard to measure coordinating work, so this
symbolic win and the fact that things go smooth is quite good
benchmark. I consider you not only good icon designer, but also
talented project manager. Thanks! ❤️
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3069 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Am-e5h9rDSNeLek3gDK5SRsSMbgp39uMks5udD9bgaJpZM4SCwwJ>.
|
|
That's the one which was annoying me all the summer because I see it every Sunday, and it was reminding mi lack of the icon on and on: https://www.openstreetmap.org/node/5404985083 If I would have some bicycle accident in the last week of my summer break and I will loose my memory. I would can at least find bicycle repair station on the map 😅 Thanks to all involved! |
|
Have a subborn little tile here. Dirty! Dirty! Dirty!.
I guess it has ADS. |
A public-access stations equipped usually with air pump, screwdriver, wrenches, allen keys etc. Very useful feature.
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbicycle_repair_station
About 2800 uses.
https://taginfo.openstreetmap.org/tags/amenity=bicycle_repair_station
Icon proposal:
The text was updated successfully, but these errors were encountered: