Clean up waterways #624
Closed
Clean up waterways #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge definitions of canal and river (canals are now as wide as rivers instead or wider on some and narrower on other zoomlevels). * Merge definitions of stream, drain, and ditch. * Render river/canal in tunnel like stream/drain/ditch in tunnel. * Render river/canal in tunnel in tunnel-style on z12 and z13. * Render tunnel=culvert like tunnel=yes. This solves the following issues: * Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11 * Fixes 4227 (trac): canals as tunnels render differently at low zooms * Fixes 4507 (trac): Waterways in a tunnel may be confused for roads * Fixes 4656 (trac): waterway=canal too wide compared with highways at z14 * Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway * Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check * Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible With thanks to @yarl for the work on gravitystorm#198.
This was referenced Jul 8, 2014
Merged
|
Superseded by #722. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead or wider on some and narrower on other zoomlevels).
This solves the following issues:
With thanks to @yarl for the work on #198.