Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizr 3.0 #1740

Closed
roblarsen opened this issue Oct 7, 2015 · 5 comments
Closed

Modernizr 3.0 #1740

roblarsen opened this issue Oct 7, 2015 · 5 comments

Comments

@roblarsen
Copy link
Member

Modernisr 3.0 is out the door! Big round of applause! Awesome job!

H5BP is still running 2.8.3. This seems like a great time to take a look at the way Modernizr is used here. This is especially true since a lot of the activity on the Modernizr repo over the past few weeks is centering around getting people up and running with custom builds and (conversely) the idea of default builds.

So, hey! Discuss! What should the version of Modernizr that H5BP ships look like. Some standard set of detects? No detects at all? Does it ship Modernizr at all? Instead of a slimmed down Modernizr, why not just the HTML5shiv? What about a world with no IE8?

Related issues: #1605 (Move Modernizr to the bottom) and #1524 (Drop IE8 Support)

@alrra
Copy link
Member

alrra commented Oct 7, 2015

Cc: @patrickkettner

@JoshuaJones
Copy link

At the bare minimum level, I'd vote for the shivs (html5shiv & printshiv). A discussion of what falls into a "standard set" of detects will probably be a long back and forth.

@patrickkettner
Copy link
Contributor

@JoshuaJones

I'd vote for the shivs (html5shiv & printshiv)

Just as an FYI - html5shiv is just the html5 shiv, but the printshiv is both the html5shiv and the printshiv. No reason for both.

@roblarsen roblarsen modified the milestone: 6.0.0 Sep 30, 2016
@roblarsen roblarsen changed the title Modernizr 3.0 discussion Modernizr 3.0 Mar 20, 2017
@roblarsen
Copy link
Member Author

Oh heck, I'm really serious about getting to zero issues and releasing a new version. Holy cow.

I started a branch where I added a config I took a stab at some interesting new tests (it felt most of the old ones aren't as interesting or useful anymore). I'll add generating it t to the build task which will introduce our users to building it. Most people will still just use the default, but we will have an opportunity to educate along the way. Woo-hoo.

@roblarsen
Copy link
Member Author

  • Add Modernizr config with new default tests
  • Build custom Modernizr with Gulp
  • Add tests for the file and for the correct path in index.html
  • Move Modernizr to the bottom

nibali scores first stage win at tour 2014

Here's the branch I'd love feedback on the default tests. At this point that's the last thing I'm waiting on before creating a PR for this and closing two issues.

roblarsen added a commit to roblarsen/html5-boilerplate that referenced this issue Apr 21, 2017
Fixes h5bp#1740 and h5bp#1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
roblarsen added a commit to roblarsen/html5-boilerplate that referenced this issue Apr 21, 2017
Fixes h5bp#1740 and h5bp#1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
roblarsen added a commit that referenced this issue May 28, 2017
Fixes #1740 and #1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this issue Oct 15, 2017
Fixes h5bp#1740 and h5bp#1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants