Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Modernizr 3 #1940

Merged
merged 1 commit into from
May 28, 2017
Merged

Adds Modernizr 3 #1940

merged 1 commit into from
May 28, 2017

Conversation

roblarsen
Copy link
Member

Fixes #1740 and #1605

  • removes the static custom build of modernizr
  • moves Modernizr to the bottom
  • builds a custom modernizr in gulp
  • adds tests for the generated modernizr
  • adds a modernizr config with new default tests

@roblarsen
Adds Modernizr 3
4e35d49 
Fixes h5bp#1740 and h5bp#1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
paulirish
paulirish approved these changes May 28, 2017
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! :)

@roblarsen roblarsen merged commit 2ad7077 into h5bp:master May 28, 2017
@roblarsen roblarsen deleted the modernizr-3 branch June 5, 2017 20:28
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
@roblarsen
Adds Modernizr 3 (h5bp#1940)
5c596cd 
Fixes h5bp#1740 and h5bp#1605

- removes the static custom build of modernizr
- moves Modernizr to the bottom
- builds a custom modernizr in gulp
- adds tests for the generated modernizr
@dreiqvd
Copy link

dreiqvd commented Oct 17, 2017

Hi. I wonder why modernizr has been moved to bottom. From what I know before, it speeds up performance when put in the <head> tags. Thanks! And sorry, I've not been updated much.

@paulirish
Copy link
Member

@dreiquevada

deets on that:

Modernizr/Modernizr#878 (comment)
https://webperf.ninja/2015/be-mindful-with-modernizr/

@dreiqvd
Copy link

dreiqvd commented Oct 17, 2017

I see. That makes sense to me now. Thank you Paul! Best regards, awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roblarsen @dreiqvd @paulirish