Enable dist files to work with CommonJS AND amd-style/require.js #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to make sure that the unit tests are functioning here. It looks like these changes break the ruby context that some of the tests are run under due to the change in the global variable scope. |
|
Any news about integrating this? |
|
All right, I'd say someone common to commonJS (pun intended) should add support for that (probably #500) and #509 should be used for AMD/require.js style. I don't see any benefit in trying to do both. |
| if (typeof window === 'object') { window.Handlebars = Handlebars; } else | ||
|
|
||
| // node.js | ||
| if (typeof global === 'object') { global.Handlebars = Handlebars; } |
There was a problem hiding this comment.
This is bad -- you don't want to force Handlebars to be exposed as a global. Probably this if...else tree should just live in the browser-prefix.js file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposition to make handlebars.js even more compatible with library styles. It add's compatibility to the amd-style (require.js) and includes #500 for building compatibility to CommonJS and not polluting global namespace anymore.
…or it might be a sign that making compatible to should find and end somewhere…