Support AMD and CommonJS out of the box

[spikebrehm]

This add support for both AMD and CommonJS, falling back to typical browser behavior. This is very similar to #501, but a bit cleaner. This also obviates #500 and #509.

It would be awesome to support these module loaders out of the box, preventing developers from using forks to support their projects (as I have had to do). Browserify does enable the use of Handlebars + CommonJS in the client side, but only with a fancy AST-walk in a build step; it makes sense to allow CommonJS without a fancy build step.

Specs are passing:

Finished in 0.24254 seconds
202 examples, 0 failures

> handlebars@1.0.11 test /Users/spike/code/spikebrehm/handlebars.js
> node_modules/.bin/mocha -u qunit spec/qunit_spec.js


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․

  134 tests complete (121 ms)

[kpdecker]

This is something that we will likely do in the 1.1 timeframe. I'm a bit hesitant to release this for the first time in the 1.0 final release.

[spikebrehm]

Thanks @kpdecker! Would it be possible to publish a 1.0.13 NPM module that includes this change?

[kpdecker]

I hope to have a 1.1.0-alpha.01 by the end of the weekend. This should also
unify the version numbers problem that we have been having.

On Fri, May 31, 2013 at 4:11 PM, Spike Brehm notifications@gitpro.ttaallkk.topwrote:

Thanks @kpdecker https://github.com/kpdecker! Would it be possible to
publish a 1.0.13 NPM module that includes this change?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/537#issuecomment-18768831
.

[spikebrehm]

Any news on a 1.1.0-alpha.01, or even a 1.0.13? Thanks!

[spikebrehm]

ping

[kpdecker]

@spikebrehm I've been holding off on a formal release of the current CommonJS code (it is available in master) as I'm waiting to see where @wycats work noted above goes. They both solve the same problem but in very different ways.

Basically I'd like to avoid flip flopping on the recommended behavior even if it's done in a alpha release.

[spikebrehm]

Got it, thanks for the response. In the meantime, I'm just working off a
fork that includes the CommonJS commit.

On Sun, Jul 14, 2013 at 1:32 PM, Kevin Decker notifications@gitpro.ttaallkk.topwrote:

@spikebrehm https://github.com/spikebrehm I've been holding off on a
formal release of the current CommonJS code (it is available in master) as
I'm waiting to see where @wycats https://github.com/wycats work noted
above goes. They both solve the same problem but in very different ways.

Basically I'd like to avoid flip flopping on the recommended behavior even
if it's done in a alpha release.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/537#issuecomment-20943219
.

Spike Brehm
Software Engineer
www.airbnb.com

San Francisco, CA, USA
C: (602) 828-2358
See how Airbnb works https://www.airbnb.com/info/how_it_works

[wycats]

I'm back from Australia and now that ES6 Module Transpiler is up to date I should be able to make some progress on mornings this week.

[kpdecker]

Released in 1.1.0

[spikebrehm]

Yay! Thanks @kpdecker 🍻