Contributing: add grunt command for tests [ci-skip] #2700
Conversation
marcandre
force-pushed
the
running_tests
branch
from
14aa95f
to
a5a396c
Compare
| Once you're configured, building the JavaScript from the command line is easy: | ||
| Once you're configured, `grunt` tasks are available: | ||
|
|
||
| grunt test # translate CoffeeScript and run the tests in spec/ |
There was a problem hiding this comment.
Not sure about "translate". We speak of "build" later on, but maybe we should all replace that for "compile".
CoffeeScript is a little language that compiles into JavaScript.
http://coffeescript.org
There was a problem hiding this comment.
I would stick with "build Chosen and run the tests in spec/", and move this line to the second one after grunt build, which implicitly specifies what "build Chosen" means.
There was a problem hiding this comment.
How about "run the tests in spec/ from CoffeeScript source".
I wouldn't talk about 'build' since grunt build does a bunch of additional stuff.
There was a problem hiding this comment.
I'm now thinking, is the addition "from CoffeeScript source" even necessary?
There was a problem hiding this comment.
Probably not. Removed.
marcandre
force-pushed
the
running_tests
branch
from
a5a396c
to
2685bc8
Compare
marcandre
force-pushed
the
running_tests
branch
from
2685bc8
to
105b019
Compare
|
@tjschuck got anything to add to this? |
* tag 'v1.7.0': (76 commits) Go to 1.7.0 add max_shown_results spec for prototype replace event.simulate for simulant library update grunt tasks rename _template functions to _html move style block to external css file move html templates to abstract class rewrite search_field_scale to prevent CSP errors add Content-Security-Policy to html consider disabled fieldset for disabled state (harvesthq#2718) only prevent default on touchevents when results are not showing (harvesthq#2725) clip results instead of moving them (harvesthq#2727) prevent action on clipboard events when disabled (harvesthq#2722) prevent activating disabled fields (harvesthq#2721) always close on chosen:close event (harvesthq#2711) restore focus if chosen was activated (harvesthq#2710) Contributing: add grunt command for tests [ci-skip] (harvesthq#2700) do not clear search text on multi selection (harvesthq#2709) escape default text (harvesthq#2712) add white-space: pre for search field scaling (harvesthq#2714) ...
A small edit to the 'grunt' section of the
Contributingto list the importantgrunt testcommand.As an experienced dev, the only thing I really need to know when wanting to write a PR is how to run the tests, and that was missing.