only prevent default on touchevents when results are not showing #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
tablet-fixes
branch
from
8774b66
to
2718e34
Compare
|
ping ✨ @harvesthq/chosen-developers @stof |
|
LGTM 👍 |
|
Any chance of releasing a package containing this fix sometime soon? It would be much appreciated. |
|
v1.7.0 has just been released |
sdemjanenko
added a commit
to meraki/chosen
that referenced
this pull request
Aug 14, 2017
* tag 'v1.7.0': (76 commits) Go to 1.7.0 add max_shown_results spec for prototype replace event.simulate for simulant library update grunt tasks rename _template functions to _html move style block to external css file move html templates to abstract class rewrite search_field_scale to prevent CSP errors add Content-Security-Policy to html consider disabled fieldset for disabled state (harvesthq#2718) only prevent default on touchevents when results are not showing (harvesthq#2725) clip results instead of moving them (harvesthq#2727) prevent action on clipboard events when disabled (harvesthq#2722) prevent activating disabled fields (harvesthq#2721) always close on chosen:close event (harvesthq#2711) restore focus if chosen was activated (harvesthq#2710) Contributing: add grunt command for tests [ci-skip] (harvesthq#2700) do not clear search text on multi selection (harvesthq#2709) escape default text (harvesthq#2712) add white-space: pre for search field scaling (harvesthq#2714) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix introduced in #2119 prevented all further touch interaction with Chosen like scrolling or selecting options.
I don't know how that has been in there for so long...
I've now updated that to only
preventDefaultthe events when the results are not showing.fixes #2289
fixes #2443